-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Packet Data type #449
Comments
I think the data field should be repeated |
I was thinking the same until I considered that depending on the Open to ideas, just food for thought :) |
An Any is: type Any struct {
TypeURL string
Value []byte
} Thus even if the Type isn't |
Ah, yes that makes sense! I agree let's do |
Co-authored-by: Mark <mjackson@microtick.com>
* refactor connection handshake update messages * refactor channel update msg handling * fix chain id for timeout * fix build * refactor state based relaying (fixes update client bug on retries) (cosmos#435) * bump sdk version to v0.41.3 (cosmos#430) * bump sdk version * bump SDK to v0.41.3 * inital work for refactoring state based relaying * Modify relayPacketFromSequence * update tendermint client to not prune light blocks (cosmos#437) * Address comments and fix lint issues * Fix lint issues * Remove onRtyErr (lint issue) * typo fix (cosmos#438) * disable tm pruning (cosmos#441) * update release naming (cosmos#442) * Implement swagger docs and fix path validation (cosmos#434) * Add swagger setup * Add some routes docs and swagger ui * Add few more route docs * Add swagger docs for remaining routes * Fix golint issues * Fix unused lint issues * check chain-id in AddChain * add a light client database lock (cosmos#447) Add a lock to prevent multiple processes from attempting to access the light client database at the same time. This typically resulted in unnecessary errors or even panics * Close database connection even if second error triggers (cosmos#449) Co-authored-by: Mark <mjackson@microtick.com> * address comments Co-authored-by: akhilkumarpilli <akhilkumar7947@gmail.com> Co-authored-by: Afanti <fanjiahe2000@163.com> Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com> Co-authored-by: Mark | Microtick <409166+mark-microtick@users.noreply.github.com> Co-authored-by: Mark <mjackson@microtick.com> Co-authored-by: akhilkumarpilli <akhilkumar7947@gmail.com> Co-authored-by: Afanti <fanjiahe2000@163.com> Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com> Co-authored-by: Mark | Microtick <409166+mark-microtick@users.noreply.github.com> Co-authored-by: Mark <mjackson@microtick.com>
Summary
Update
IBCAccountPacketData
to have the following definition:Investigate if we can remove
IBCTxRaw
& only useIBCTxBody
. Future versions of ICA may use the data field for use other than executing messages which we need to take into consideration.For Admin Use
The text was updated successfully, but these errors were encountered: