fix: base option of vuepress for correct asset paths #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
AdityaSripal,
charleenfei,
colin-axner,
damiannolan and
seantking
as code owners
damiannolan
approved these changes
Sep 22, 2021
|
I may not merge this PR because the problem might solve by itself once we get the |
colin-axner
approved these changes
Sep 22, 2021
|
It works, no need for this PR anymore. This reminded me how to fix things 😆 |
faddat
pushed a commit
to notional-labs/ibc-go
that referenced
this pull request
Feb 23, 2022
Use Label from contract's instantiate message
faddat
pushed a commit
to notional-labs/ibc-go
that referenced
this pull request
Mar 1, 2022
* bump sdk version * bump SDK to v0.41.3
faddat
pushed a commit
to notional-labs/ibc-go
that referenced
this pull request
Mar 1, 2022
* refactor connection handshake update messages * refactor channel update msg handling * fix chain id for timeout * fix build * refactor state based relaying (fixes update client bug on retries) (cosmos#435) * bump sdk version to v0.41.3 (cosmos#430) * bump sdk version * bump SDK to v0.41.3 * inital work for refactoring state based relaying * Modify relayPacketFromSequence * update tendermint client to not prune light blocks (cosmos#437) * Address comments and fix lint issues * Fix lint issues * Remove onRtyErr (lint issue) * typo fix (cosmos#438) * disable tm pruning (cosmos#441) * update release naming (cosmos#442) * Implement swagger docs and fix path validation (cosmos#434) * Add swagger setup * Add some routes docs and swagger ui * Add few more route docs * Add swagger docs for remaining routes * Fix golint issues * Fix unused lint issues * check chain-id in AddChain * add a light client database lock (cosmos#447) Add a lock to prevent multiple processes from attempting to access the light client database at the same time. This typically resulted in unnecessary errors or even panics * Close database connection even if second error triggers (cosmos#449) Co-authored-by: Mark <mjackson@microtick.com> * address comments Co-authored-by: akhilkumarpilli <akhilkumar7947@gmail.com> Co-authored-by: Afanti <fanjiahe2000@163.com> Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com> Co-authored-by: Mark | Microtick <409166+mark-microtick@users.noreply.github.com> Co-authored-by: Mark <mjackson@microtick.com> Co-authored-by: akhilkumarpilli <akhilkumar7947@gmail.com> Co-authored-by: Afanti <fanjiahe2000@163.com> Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com> Co-authored-by: Mark | Microtick <409166+mark-microtick@users.noreply.github.com> Co-authored-by: Mark <mjackson@microtick.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ibc-docs website is not rendered properly because loading of assets is failing with 404. For example: the site tries to load https://cosmos.github.io/main/favicon-16x16.png and it fails, but the asset is actually located in https://cosmos.github.io/ibc-docs/main/favicon-16x16.png.
To fix this the vuepress documentation says that we need to set the
baseoption to (in our case)/ibc-docs/. It cannot be just/because the site is deployed to a non-root URL.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes