refactor: adding check if channel exists before register counterparty #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seantking
commented
May 4, 2022
colin-axner
reviewed
May 4, 2022
seantking
requested review from
AdityaSripal,
crodriguezvega,
charleenfei and
damiannolan
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1339 +/- ##
==========================================
+ Coverage 80.27% 80.29% +0.01%
==========================================
Files 166 166
Lines 12023 12034 +11
==========================================
+ Hits 9652 9663 +11
Misses 1916 1916
Partials 455 455
|
colin-axner
approved these changes
May 11, 2022
CHANGELOG.md
Outdated
| @@ -49,6 +49,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| ### Improvements | |||
|
|
|||
| * (modules/app/29-fee) [\#1339](https://github.com/cosmos/ibc-go/pull/1339) The `RegisterCounterpartyAddress` gRPC endpoint now checks if the channel exists before registering. | |||
There was a problem hiding this comment.
Changelog entry isn't super necessary since we haven't release ics29, but guess it doesn't hurt
AdityaSripal
approved these changes
May 12, 2022
| @@ -101,18 +101,18 @@ func NewPayPacketFeeAsyncTxCmd() *cobra.Command { | |||
| // NewRegisterCounterpartyAddress returns the command to create a MsgRegisterCounterpartyAddress | |||
| func NewRegisterCounterpartyAddress() *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "register-counterparty [address] [counterparty-address] [channel-id]", | |||
| Use: "register-counterparty [address] [counterparty-address] [channel-id] [port-id]", | |||
There was a problem hiding this comment.
It would be more consistent with the rest of CLIs if the order of the arguments is reversed, so [port-id] [channel-id] instead of [channel-id] [port-id].
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| clientCtx, err := client.GetClientTxContext(cmd) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| msg := types.NewMsgRegisterCounterpartyAddress(args[0], args[1], args[2]) | ||
| msg := types.NewMsgRegisterCounterpartyAddress(args[0], args[1], args[2], args[3]) |
There was a problem hiding this comment.
And I think this is wrong because args[3] is the port-id, but it should pass the channel-id as the last argument... But if we revert the order of the CLI parameters, then this will be fine. :)
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to add this check we needed access to the PortID. I have added portID to the Msg + updated CLI etc. Wdyt?
closes: #1322
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes