refactor: rename genesis type RegisteredRelayer to RegisteredCounterpartyPayee #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Charly <charly@interchain.berlin>
…e-genesis-register-counterparty-addr
damiannolan
requested review from
AdityaSripal,
seantking,
charleenfei,
colin-axner,
fedekunze,
crodriguezvega and
chatton
as code owners
9 tasks
Codecov Report
@@ Coverage Diff @@
## main #1514 +/- ##
=======================================
Coverage 80.24% 80.25%
=======================================
Files 166 166
Lines 12254 12274 +20
=======================================
+ Hits 9833 9850 +17
- Misses 1957 1959 +2
- Partials 464 465 +1
|
damiannolan
commented
Jun 14, 2022
| @@ -259,22 +259,22 @@ func (suite *KeeperTestSuite) TestGetAllFeeEnabledChannels() { | |||
| } | |||
|
|
|||
| func (suite *KeeperTestSuite) TestGetAllRelayerAddresses() { | |||
There was a problem hiding this comment.
This test function needs to be renamed!
There was a problem hiding this comment.
I accidentally pushed this change to #1522. Doesn't make much difference really, both will be merged one after the other
| @@ -38,19 +38,20 @@ message FeeEnabledChannel { | |||
| // RegisteredPayee contains the relayer address and payee address for a specific channel | |||
| message RegisteredPayee { | |||
| // the relayer address | |||
| string relayer_address = 1 [(gogoproto.moretags) = "yaml:\"relayer_address\""]; | |||
| string relayer = 1; | |||
| // the payee address | |||
| string payee = 2; | |||
| // unique channel identifier | |||
| string channel_id = 3 [(gogoproto.moretags) = "yaml:\"channel_id\""]; | |||
There was a problem hiding this comment.
This is a nit, but should we move the channel_id to the first position? Usually we have the port_id and channel_id in the first positions of the messages?
There was a problem hiding this comment.
I don't feel very strong about this tbh. I'll go ahead and make the change and get this merged
| string counterparty_address = 2 [(gogoproto.moretags) = "yaml:\"counterparty_address\""]; | ||
| string relayer = 1; | ||
| // the counterparty payee address | ||
| string counterparty_payee = 2 [(gogoproto.moretags) = "yaml:\"counterparty_payee\""]; | ||
| // unique channel identifier | ||
| string channel_id = 3 [(gogoproto.moretags) = "yaml:\"channel_id\""]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renaming
GenesisStatefield toRegisteredCounterpartyPayeeto alignneeds: #1513
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes