Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename CounterpartyAddress query to CounterpartyPayee #1522

Merged
merged 18 commits into from
Jun 15, 2022

Conversation

damiannolan
Copy link
Member

Description

Renaming grpc query and CLI to reflect changes: CounterpartyAddress -> CounterpartyPayee

needs: #1513 #1514
closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2022

Codecov Report

Merging #1522 (0a71631) into main (0252bfb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1522   +/-   ##
=======================================
  Coverage   80.25%   80.25%           
=======================================
  Files         166      166           
  Lines       12274    12274           
=======================================
  Hits         9850     9850           
  Misses       1959     1959           
  Partials      465      465           
Impacted Files Coverage Δ
modules/apps/29-fee/keeper/genesis.go 87.50% <100.00%> (ø)
modules/apps/29-fee/keeper/grpc_query.go 75.54% <100.00%> (ø)
modules/apps/29-fee/keeper/keeper.go 92.48% <100.00%> (ø)

Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@damiannolan damiannolan merged commit a71fc10 into main Jun 15, 2022
@damiannolan damiannolan deleted the damian/rename-counterparty-addr-query branch June 15, 2022 10:09
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants