improve error messages, indicate already relayed packets #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
commented
May 21, 2021
5 tasks
colin-axner
commented
May 21, 2021
Codecov Report
@@ Coverage Diff @@
## main #184 +/- ##
==========================================
+ Coverage 80.05% 80.23% +0.18%
==========================================
Files 109 109
Lines 6482 6491 +9
==========================================
+ Hits 5189 5208 +19
+ Misses 936 928 -8
+ Partials 357 355 -2
|
AdityaSripal
requested changes
May 24, 2021
AdityaSripal
approved these changes
May 26, 2021
cwgoes
reviewed
May 28, 2021
| @@ -462,6 +470,10 @@ func (k Keeper) AcknowledgePacket( | |||
|
|
|||
| commitment := k.GetPacketCommitment(ctx, packet.GetSourcePort(), packet.GetSourceChannel(), packet.GetSequence()) | |||
|
|
|||
| if len(commitment) == 0 { | |||
| return sdkerrors.Wrapf(types.ErrPacketCommitmentNotFound, "packet with sequence (%d) has been acknowledged, or timed out. In rare cases the packet was never sent or the packet sequence is incorrect", packet.GetSequence()) | |||
There was a problem hiding this comment.
What do you mean, "in rare cases"? In the case of incorrect relayer behaviour, perhaps?
There was a problem hiding this comment.
correct, should I rephrase? My thought process is it seems very unlikely a relayer would have a proof for a packet never sent (I'm not even sure how this would happen). The only case I can think of is if the relayer sets the packet sequence incorrectly
There was a problem hiding this comment.
I think it's worth noting that this indicates some relayer misconfiguration, yeah. Very minor though.
cwgoes
reviewed
May 28, 2021
| @@ -80,6 +80,10 @@ func (k Keeper) TimeoutPacket( | |||
|
|
|||
| commitment := k.GetPacketCommitment(ctx, packet.GetSourcePort(), packet.GetSourceChannel(), packet.GetSequence()) | |||
|
|
|||
| if len(commitment) == 0 { | |||
| return sdkerrors.Wrapf(types.ErrPacketCommitmentNotFound, "packet with sequence (%d) has been acknowledged or timed out. In rare cases the packet was never sent or the packet sequence is incorrect", packet.GetSequence()) | |||
There was a problem hiding this comment.
Ditto on the rare cases question
CosmosCar
pushed a commit
to caelus-labs/ibc-go
that referenced
this pull request
Nov 6, 2023
CosmosCar
pushed a commit
to caelus-labs/ibc-go
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #152
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes