improve error messages #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
commented
May 28, 2021
| @@ -568,7 +568,7 @@ func produceVerificationArgs( | |||
|
|
|||
| consensusState, err = GetConsensusState(store, cdc, height) | |||
| if err != nil { | |||
| return commitmenttypes.MerkleProof{}, nil, err | |||
| return commitmenttypes.MerkleProof{}, nil, sdkerrors.Wrap(err, "please ensure the proof was constructed against the height the client was updated to") | |||
There was a problem hiding this comment.
any other way to word this?
Codecov Report
@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 80.26% 80.26%
=======================================
Files 109 109
Lines 6485 6485
=======================================
Hits 5205 5205
Misses 925 925
Partials 355 355
|
Co-authored-by: Aditya <adityasripal@gmail.com>
fedekunze
approved these changes
Jun 3, 2021
|
we are adding a stracktrace for error messages, in case you are interested in taking a look: evmos/ethermint#50 |
CosmosCar
pushed a commit
to caelus-labs/ibc-go
that referenced
this pull request
Nov 6, 2023
…n to ensure PENDING-CHANGELOG.md is updated on every commit to main (cosmos#203)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
addresses comment
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes