chore: add deprecated option to create_localhost
#3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
DimitrisJim
reviewed
Jun 19, 2023
| @@ -18,8 +18,9 @@ message GenesisState { | |||
| // metadata from each client | |||
| repeated IdentifiedGenesisMetadata clients_metadata = 3 [(gogoproto.nullable) = false]; | |||
| Params params = 4 [(gogoproto.nullable) = false]; | |||
| // create localhost on initialization | |||
| bool create_localhost = 5; | |||
| // Deprecated: create_localhost has been deprecated. | |||
There was a problem hiding this comment.
micro nit: seems like the deprecated option adds a similar comment to this so adding it here too might be on the side of redundancy 😄
There was a problem hiding this comment.
If you (or somebody else) are not strongly opinionated, then I think I will just leave it. :)
DimitrisJim
approved these changes
Jun 19, 2023
colin-axner
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The field was already marked as deprecated in the code, but not in the proto yet.
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.