Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add deprecated option to create_localhost #3892

Merged
merged 1 commit into from
Jun 19, 2023
Merged

chore: add deprecated option to create_localhost #3892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 35 additions & 33 deletions modules/core/02-client/types/genesis.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions proto/ibc/core/client/v1/genesis.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ message GenesisState {
// metadata from each client
repeated IdentifiedGenesisMetadata clients_metadata = 3 [(gogoproto.nullable) = false];
Params params = 4 [(gogoproto.nullable) = false];
// create localhost on initialization
bool create_localhost = 5;
// Deprecated: create_localhost has been deprecated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

micro nit: seems like the deprecated option adds a similar comment to this so adding it here too might be on the side of redundancy 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you (or somebody else) are not strongly opinionated, then I think I will just leave it. :)

// The localhost client is automatically created at genesis.
bool create_localhost = 5 [deprecated = true];
// the sequence for the next generated client identifier
uint64 next_client_sequence = 6;
}
Expand Down