feat: 08-wasm light client proxy module for wasm clients #5079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com> Co-authored-by: antstalepresh <stalepresh121@outlook.com> Co-authored-by: Vladislav Markushin <negigic@gmail.com> Co-authored-by: Blas Rodriguez Irizar <rodrigblas@gmail.com> Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: vuong <nguyenvuong1122000@gmail.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
* new error * changed all the errors * feat: Changed some more erros from sdkerrors to errorsmod * added ibcerrors * fixes and linting --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
* imp: add separate go.mod for 08-wasm * fix e2e build * remove import * lint * Amend CI testing to not build on arm, correctly cross compile on arm64. (#4065) * Use alpine for building simd in docker. Link statically. (#4066) --------- Co-authored-by: Charly <charly@interchain.berlin> Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
* remove code ID key from genesis type * address review comment
* bump wasmvm to v1.2.4 * go mod tidy e2e * Update Dockerfile * update libwasm sha * more go mod tidy --------- Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
* build and test wasm-client on pull request * add arm64 for wasm build only
* merge functions * address review comment
* pin code to the wasm VM cache * follow ibc-go error wrapping standards * Update modules/light-clients/08-wasm/keeper/keeper.go Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com>
* renaming to align with x/wasm naming * fix typo * Update docs/architecture/adr-027-ibc-wasm.md Co-authored-by: Damian Nolan <damiannolan@gmail.com> * address review comments * review comment --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com>
* disallow submessage execution * fix error code * alignment * fix
# Conflicts: # Dockerfile # testing/chain.go
* Add linting for 08-wasm. * Go mod tidy. * Please the linter.
* add 08-wasm global store key * Update client_state.go * Update modules/light-clients/08-wasm/types/vm.go Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> --------- Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
…n `initialize` to contract (#4033) * remove calls to set client state and consensus state from initialize * linting * Update contracts * use errorsmod --------- Co-authored-by: Vladislav Markushin <negigic@gmail.com>
…etrieve it (#4034) * imp: remove timestamp from consensus state * more linting * make types unexported * make proto-all * code hash for code id * Use hasConsensusState instead of GetConsensusState (#4171) * Use hasConsensusState instead of GetConsensusState. * Use wasmQuery for the rest of the query functions. (#4176) * Use wasmQuery for the rest of the query functions. --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * review comments * Remove check for consensus state. * Add linting for 08-wasm module (#4206) * Add linting for 08-wasm. * Go mod tidy. * Please the linter. * add 08-wasm global store key (#4185) * add 08-wasm global store key * Update client_state.go * Update modules/light-clients/08-wasm/types/vm.go Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> --------- Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> * solve conflicts * review comments/fix linter warnings * address comments * add missing check * remove check that was wrong --------- Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
…our` (#4049) * imp: merge header and misbehaviour types * remove unused code
…ce (#4109) * add constructor that accepts pointer to Wasm VM instance * typo * add functions that returns wasm config with default values * review comment * Apply suggestions from code review Co-authored-by: Cian Hatton <cian@interchain.io> * review comments * rename constructor function * address review comments * set contract debug mode to false --------- Co-authored-by: Cian Hatton <cian@interchain.io>
* Rename from call to wasmCall. * Move wasmQuery, wasmCall into vm. * Add wasmInit, mirroring wasmCall and wasmQuery. * Directly return after wasmInit.
# Conflicts: # testing/config.go
* add 08-wasm code owners * fix
charleenfei
approved these changes
Nov 15, 2023
* Add an error-ing implementation for GoAPI. * Move var to top level, add assertions in tests. * Clean up responses in sucess cases.
* Rename occurences of codehash in proto files. * Documentation. Output code_hash as json key for encoded client state. * Rename occurences triggering the compiler. * Fix issues triggering the linter. * First round of renames. * Fix rename in e2e/ * Use new contract with renamed code hash. * gzip it. * Additional soft renames. * Final one, fingers crossed. * Replace occurences in e2e/, cli.
DimitrisJim
approved these changes
Nov 15, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
Co-authored-by: Steve <steve@strange.love> Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com> Co-authored-by: antstalepresh <stalepresh121@outlook.com> Co-authored-by: Vladislav Markushin <negigic@gmail.com> Co-authored-by: Blas Rodriguez Irizar <rodrigblas@gmail.com> Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: vuong <nguyenvuong1122000@gmail.com> Co-authored-by: Vishal Potpelliwar <71565171+vishal-kanna@users.noreply.github.com> Co-authored-by: Charly <charly@interchain.berlin> Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Cian Hatton <cian@interchain.io> Co-authored-by: Adi <103246632+adiraviraj@users.noreply.github.com> Co-authored-by: chatton <github.qpeyb@simplelogin.fr> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Charly <charly@interchain.io> Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: Muku <44918265+muku314115@users.noreply.github.com> Co-authored-by: Pham Anh Minh <1phamminh0811@gmail.com> Co-authored-by: nguyen <trinity6569@gmail.com> (cherry picked from commit 08d36eb) # Conflicts: # .github/dependabot.yml # .github/workflows/e2e-test-workflow-call.yml # .github/workflows/e2e.yaml # .github/workflows/test.yml # .gitignore # Dockerfile # docs/.vuepress/config.js # docs/architecture/adr-027-ibc-wasm.md # docs/client/config.json # docs/client/swagger-ui/swagger.yaml # docs/ibc/proposals.md # e2e/go.mod # e2e/go.sum # e2e/relayer/relayer.go # e2e/sample.config.yaml # e2e/scripts/run-e2e.sh # e2e/tests/core/02-client/client_test.go # e2e/tests/interchain_accounts/base_test.go # e2e/tests/interchain_accounts/gov_test.go # e2e/tests/interchain_accounts/groups_test.go # e2e/tests/interchain_accounts/incentivized_test.go # e2e/tests/interchain_accounts/localhost_test.go # e2e/tests/interchain_accounts/params_test.go # e2e/tests/transfer/base_test.go # e2e/tests/upgrades/genesis_test.go # e2e/tests/upgrades/upgrade_test.go # e2e/testsuite/codec.go # e2e/testsuite/grpc_query.go # e2e/testsuite/testconfig.go # e2e/testsuite/testsuite.go # e2e/testsuite/tx.go # e2e/testvalues/values.go # go.work.example # modules/core/02-client/types/params.go # scripts/go-lint-all.sh # scripts/go-mod-tidy-all.sh # testing/chain.go
mergify bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
Co-authored-by: Steve <steve@strange.love> Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com> Co-authored-by: antstalepresh <stalepresh121@outlook.com> Co-authored-by: Vladislav Markushin <negigic@gmail.com> Co-authored-by: Blas Rodriguez Irizar <rodrigblas@gmail.com> Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: vuong <nguyenvuong1122000@gmail.com> Co-authored-by: Vishal Potpelliwar <71565171+vishal-kanna@users.noreply.github.com> Co-authored-by: Charly <charly@interchain.berlin> Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Cian Hatton <cian@interchain.io> Co-authored-by: Adi <103246632+adiraviraj@users.noreply.github.com> Co-authored-by: chatton <github.qpeyb@simplelogin.fr> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Charly <charly@interchain.io> Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: Muku <44918265+muku314115@users.noreply.github.com> Co-authored-by: Pham Anh Minh <1phamminh0811@gmail.com> Co-authored-by: nguyen <trinity6569@gmail.com> (cherry picked from commit 08d36eb) # Conflicts: # .github/workflows/e2e-test-workflow-call.yml # .github/workflows/e2e.yaml # .github/workflows/test.yml # docs/architecture/adr-027-ibc-wasm.md # docs/docs/01-ibc/06-proposals.md # e2e/go.mod # e2e/go.sum # e2e/relayer/relayer.go # e2e/sample.config.yaml # e2e/scripts/run-e2e.sh # e2e/tests/core/02-client/client_test.go # e2e/tests/interchain_accounts/base_test.go # e2e/tests/interchain_accounts/gov_test.go # e2e/tests/interchain_accounts/groups_test.go # e2e/tests/interchain_accounts/incentivized_test.go # e2e/tests/interchain_accounts/localhost_test.go # e2e/tests/interchain_accounts/params_test.go # e2e/tests/transfer/base_test.go # e2e/tests/upgrades/genesis_test.go # e2e/tests/upgrades/upgrade_test.go # e2e/testsuite/codec.go # e2e/testsuite/grpc_query.go # e2e/testsuite/testconfig.go # e2e/testsuite/testsuite.go # e2e/testsuite/tx.go # e2e/testvalues/values.go # scripts/go-mod-tidy-all.sh
9 tasks
crodriguezvega
added a commit
that referenced
this pull request
Nov 28, 2023
) (#5121) * feat: 08-wasm light client proxy module for wasm clients (#5079) Co-authored-by: Steve <steve@strange.love> Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com> Co-authored-by: antstalepresh <stalepresh121@outlook.com> Co-authored-by: Vladislav Markushin <negigic@gmail.com> Co-authored-by: Blas Rodriguez Irizar <rodrigblas@gmail.com> Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: vuong <nguyenvuong1122000@gmail.com> Co-authored-by: Vishal Potpelliwar <71565171+vishal-kanna@users.noreply.github.com> Co-authored-by: Charly <charly@interchain.berlin> Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Cian Hatton <cian@interchain.io> Co-authored-by: Adi <103246632+adiraviraj@users.noreply.github.com> Co-authored-by: chatton <github.qpeyb@simplelogin.fr> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Charly <charly@interchain.io> Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: Muku <44918265+muku314115@users.noreply.github.com> Co-authored-by: Pham Anh Minh <1phamminh0811@gmail.com> Co-authored-by: nguyen <trinity6569@gmail.com> (cherry picked from commit 08d36eb) # Conflicts: # .github/workflows/e2e-test-workflow-call.yml # .github/workflows/e2e.yaml # .github/workflows/test.yml # docs/architecture/adr-027-ibc-wasm.md # docs/docs/01-ibc/06-proposals.md # e2e/go.mod # e2e/go.sum # e2e/relayer/relayer.go # e2e/sample.config.yaml # e2e/scripts/run-e2e.sh # e2e/tests/core/02-client/client_test.go # e2e/tests/interchain_accounts/base_test.go # e2e/tests/interchain_accounts/gov_test.go # e2e/tests/interchain_accounts/groups_test.go # e2e/tests/interchain_accounts/incentivized_test.go # e2e/tests/interchain_accounts/localhost_test.go # e2e/tests/interchain_accounts/params_test.go # e2e/tests/transfer/base_test.go # e2e/tests/upgrades/genesis_test.go # e2e/tests/upgrades/upgrade_test.go # e2e/testsuite/codec.go # e2e/testsuite/grpc_query.go # e2e/testsuite/testconfig.go # e2e/testsuite/testsuite.go # e2e/testsuite/tx.go # e2e/testvalues/values.go # scripts/go-mod-tidy-all.sh * rm e2e folder. * rm build step for e2es in test.yml * Fix conflict in proposals doc. * Fix conflict in ADR. * remove pin to local ibc-go * Revert "remove pin to local ibc-go" This reverts commit 7204fa2. * address review comments --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
damiannolan
pushed a commit
that referenced
this pull request
Nov 29, 2023
* feat: 08-wasm light client proxy module for wasm clients (#5079) Co-authored-by: Steve <steve@strange.love> Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com> Co-authored-by: antstalepresh <stalepresh121@outlook.com> Co-authored-by: Vladislav Markushin <negigic@gmail.com> Co-authored-by: Blas Rodriguez Irizar <rodrigblas@gmail.com> Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: vuong <nguyenvuong1122000@gmail.com> Co-authored-by: Vishal Potpelliwar <71565171+vishal-kanna@users.noreply.github.com> Co-authored-by: Charly <charly@interchain.berlin> Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Cian Hatton <cian@interchain.io> Co-authored-by: Adi <103246632+adiraviraj@users.noreply.github.com> Co-authored-by: chatton <github.qpeyb@simplelogin.fr> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Charly <charly@interchain.io> Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: Muku <44918265+muku314115@users.noreply.github.com> Co-authored-by: Pham Anh Minh <1phamminh0811@gmail.com> Co-authored-by: nguyen <trinity6569@gmail.com> (cherry picked from commit 08d36eb) # Conflicts: # .github/dependabot.yml # .github/workflows/e2e-test-workflow-call.yml # .github/workflows/e2e.yaml # .github/workflows/test.yml # .gitignore # Dockerfile # docs/.vuepress/config.js # docs/architecture/adr-027-ibc-wasm.md # docs/client/config.json # docs/client/swagger-ui/swagger.yaml # docs/ibc/proposals.md # e2e/go.mod # e2e/go.sum # e2e/relayer/relayer.go # e2e/sample.config.yaml # e2e/scripts/run-e2e.sh # e2e/tests/core/02-client/client_test.go # e2e/tests/interchain_accounts/base_test.go # e2e/tests/interchain_accounts/gov_test.go # e2e/tests/interchain_accounts/groups_test.go # e2e/tests/interchain_accounts/incentivized_test.go # e2e/tests/interchain_accounts/localhost_test.go # e2e/tests/interchain_accounts/params_test.go # e2e/tests/transfer/base_test.go # e2e/tests/upgrades/genesis_test.go # e2e/tests/upgrades/upgrade_test.go # e2e/testsuite/codec.go # e2e/testsuite/grpc_query.go # e2e/testsuite/testconfig.go # e2e/testsuite/testsuite.go # e2e/testsuite/tx.go # e2e/testvalues/values.go # go.work.example # modules/core/02-client/types/params.go # scripts/go-lint-all.sh # scripts/go-mod-tidy-all.sh # testing/chain.go * rm e2e related stuff. * paths point to ibc-go/v7. * Fix some of the conflicts in code. * chore: wip * fix conflicts * add wasmvm import & use ibc-go v7.3.0 tag * remove CLI for submitting gov proposal to store code (only supported from SDK v0.50) * re-implement GetSigners for 08-wasm messages * Fix test in codec_test.go. * Fix storetypes import. * Revert changes to module.go * Use testing.T, call GetEvents from sdk.Result in wasm_endpoint. * comment out usages of collections. * go build finally working, my soul is dark. * Add snapshotter registration to simapp. * Remove last occurence of duplicate import. * Regen proto for Checksums. * green 08-wasm tests. * shhhh linter, its all okay. * Pls * remove docs folder that did not exist in the release branch * rm unecessary files for e2e's, makefile changes, config.js, go.work.example. * Docustrings for store ops, use fallible serialization funcs. * Remove superfluous init of WasmKeeper before checking for mockVM. * remove table item with broken link * remove broken link * Revert "remove CLI for submitting gov proposal to store code (only supported from SDK v0.50)" This reverts commit 7e9f5ea. * deps: bump SDK to v0.47.6 --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: chatton <github.qpeyb@simplelogin.fr>
hoangdv2429
pushed a commit
to hoangdv2429/ibc-go
that referenced
this pull request
Dec 9, 2023
Co-authored-by: Steve <steve@strange.love> Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com> Co-authored-by: antstalepresh <stalepresh121@outlook.com> Co-authored-by: Vladislav Markushin <negigic@gmail.com> Co-authored-by: Blas Rodriguez Irizar <rodrigblas@gmail.com> Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: vuong <nguyenvuong1122000@gmail.com> Co-authored-by: Vishal Potpelliwar <71565171+vishal-kanna@users.noreply.github.com> Co-authored-by: Charly <charly@interchain.berlin> Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Cian Hatton <cian@interchain.io> Co-authored-by: Adi <103246632+adiraviraj@users.noreply.github.com> Co-authored-by: chatton <github.qpeyb@simplelogin.fr> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Charly <charly@interchain.io> Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: Muku <44918265+muku314115@users.noreply.github.com> Co-authored-by: Pham Anh Minh <1phamminh0811@gmail.com> Co-authored-by: nguyen <trinity6569@gmail.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Co-authored-by: Jack Zampolin jack.zampolin@gmail.com
Co-authored-by: Steve steve@strange.love
Co-authored-by: antstalepresh stalepresh121@outlook.com
Co-authored-by: Vladislav Markushin negigic@gmail.com
Co-authored-by: Blas Rodriguez Irizar rodrigblas@gmail.com
Co-authored-by: Jacob Gadikian jacobgadikian@gmail.com
Co-authored-by: vuong nguyenvuong1122000@gmail.com
Co-authored-by: Damian Nolan damiannolan@gmail.com
Co-authored-by: Charly charly@interchain.io
Co-authored-by: Colin Axnér 25233464+colin-axner@users.noreply.github.com
Co-authored-by: Cian Hatton cian@interchain.io
Co-authored-by: Jim Fasarakis-Hilliard d.f.hilliard@gmail.com
Co-authored-by: srdtrk 59252793+srdtrk@users.noreply.github.com
Co-authored-by: Pham Anh Minh 1phamminh0811@gmail.com
Co-authored-by: nguyen trinity6569@gmail.com
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.