e2e: Port tests for packet forward middleware module #8292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To satisfy my ocd kick.
DeshErBojhaa
requested review from
AdityaSripal,
gjermundgaraba and
srdtrk
as code owners
|
…o into tamjid/pfm-homecoming-tests
* Update 00-intro.md * add in middleware serialisation notice * Update 02-developIBCv2.md
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
Contributor
gjermundgaraba
left a comment
gjermundgaraba
left a comment
There was a problem hiding this comment.
This is looking very good! Left some comments and questions, but we should be able to merge this very soon 🙌
Great work, @DeshErBojhaa
I create this issue to track things we need to clean up, please add other things you have seen and thought about that needs to be cleaned up here: #8360
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
gjermundgaraba
approved these changes
May 9, 2025
DeshErBojhaa
added a commit
that referenced
this pull request
May 12, 2025
--------- Co-authored-by: Gjermund Garaba <gjermund@garaba.net> Co-authored-by: Susannah Evans <65018876+womensrights@users.noreply.github.com>
DeshErBojhaa
added a commit
that referenced
this pull request
May 12, 2025
--------- Co-authored-by: Gjermund Garaba <gjermund@garaba.net> Co-authored-by: Susannah Evans <65018876+womensrights@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of the epic for porting
Packet forward middlewarefromibc-apprepo toibc-gorepo.This PR deals with porting e2e tests for
packet forward middleware.This PR is created on top of #8285 which is the branch that will eventually be merged into main.
closes: #8289
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.