Skip to content

Conversation

@DeshErBojhaa
Copy link
Contributor

@DeshErBojhaa DeshErBojhaa commented Apr 9, 2025

Description

This PR ports packet-forward-middleware from ibc-apps repo.

closes: #8269


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

First commit. Porting minimum necessary files for a non broken codebase. Gradual update on this branch eventually will port all code from ibc-app -> ibc-go.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2025

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@womensrights womensrights linked an issue Apr 13, 2025 that may be closed by this pull request
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
@DeshErBojhaa DeshErBojhaa self-assigned this May 7, 2025
DeshErBojhaa and others added 14 commits May 9, 2025 22:16
---------

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
Co-authored-by: Susannah Evans <65018876+womensrights@users.noreply.github.com>
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
* delete v9 docs

* add v10.1.x versioned docs

* fix broken links

* more link fixes

---------

Co-authored-by: Susannah Evans <65018876+womensrights@users.noreply.github.com>
Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
* docs: set v10 as default

* fix migration docs
* feat: allow scaling of trusting period for client upgrades

* refactor: use sdkmath to avoid floating-point precision issues

* chore: update godocs

* chore: impl feedback and add dedicated test case

---------

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
…8282)

* fix TestSetGetTotalEscrowForDenom

* fix TestSetGetTotalEscrowForDenom

* add comment to explain where is panic

* test(transfer): construct Coin manually to test SetTotalEscrowForDenom panic logic

* lint

---------

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
* chore: bump deps

* no go 1.24 plz

* fix docker filer go version
* update

* preblocker
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woho! I think we are getting ready to merge this bad boy 🙌
I'll let the tests pass and merge it afterwards 🚀

@gjermundgaraba gjermundgaraba merged commit 9ccab29 into main May 15, 2025
52 checks passed
@gjermundgaraba gjermundgaraba deleted the tamjid/pfm-homecoming branch May 15, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Packet forward middleware