chore: remove orderedmap #8555
chore: remove orderedmap #8555
Conversation
gjermundgaraba
requested review from
AdityaSripal,
DeshErBojhaa and
srdtrk
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8555 +/- ##
===========================================
+ Coverage 17.66% 58.00% +40.33%
===========================================
Files 28 317 +289
Lines 2711 22743 +20032
===========================================
+ Hits 479 13191 +12712
- Misses 2205 8948 +6743
- Partials 27 604 +577
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DeshErBojhaa
left a comment
DeshErBojhaa
left a comment
There was a problem hiding this comment.
Great PR. Robust implementation of ser/de.
Approving this as the only comment I have is a non blocker.
| return im.app.OnAcknowledgementPacket(ctx, sourceClient, destinationClient, sequence, acknowledgement, payload, relayer) | ||
| } | ||
|
|
||
| // TODO: Something looks off about this, please review carefully |
There was a problem hiding this comment.
Will you do this in this pr?
There was a problem hiding this comment.
No, I just added it because I happened to come across it.
AdityaSripal
left a comment
AdityaSripal
left a comment
There was a problem hiding this comment.
approved modulo codecov
There was a problem hiding this comment.
Pull Request Overview
This PR removes the orderedmap dependency and refactors the packet-forward middleware to use native maps and time.Duration, updating associated tests and usage across the codebase.
- Eliminated all imports and usage of
github.com/iancoleman/orderedmap. - Refactored
PacketMetadata/ForwardMetadatato use native Go types and helper methods (ToMap,ToMemo). - Updated tests and IBC middleware to use the new
ToMemoAPI andtime.Durationinstead of custom JSON wrappers.
Reviewed Changes
Copilot reviewed 18 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| simapp/go.mod & modules/**/go.mod | Removed orderedmap from module dependencies |
| modules/apps/rate-limiting/v2/ibc_middleware.go | Minor TODO addition |
| modules/apps/packet-forward-middleware/types/keys.go | Added new metadata key constants |
| modules/apps/packet-forward-middleware/types/forward.go | Removed JSONObject/orderedmap, implemented native maps |
| modules/apps/packet-forward-middleware/types/forward_test.go | Expanded tests for new API and increased coverage |
| modules/apps/packet-forward-middleware/keeper/*.go & tests | Adjusted ForwardTransferPacket signature and memo handling |
| modules/apps/packet-forward-middleware/ibc_middleware.go | Updated OnRecvPacket to use GetPacketMetadataFromPacketdata |
| e2e/tests/packet_forward_middleware/**/*.go | Updated E2E tests to use ToMemo and removed orderedmap use |
| go.mod | Removed orderedmap globally |
Comments suppressed due to low confidence (2)
modules/apps/packet-forward-middleware/types/forward.go:35
- The Validate method calls errors.New but the standard "errors" package is not imported. Add
import "errors"or replace with errorsmod.New.
func (m ForwardMetadata) Validate() error {
modules/apps/packet-forward-middleware/types/forward.go:84
- json.Marshal is used but the "encoding/json" package is not imported. Add
import "encoding/json".
packetMetadataJSON, err := json.Marshal(packetMetadataMap)
Description
closes: IBCGO-2338
closes: #8378
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) if anything is changed.godoccomments if relevant.Files changedin the GitHub PR explorer.