Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ClientState not optional in MsgConnectionOpen{Try,Ack} #160

Merged
merged 6 commits into from
Oct 11, 2022

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Oct 7, 2022

Closes: #159


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@plafer plafer requested a review from hu55a1n1 October 7, 2022 17:46
@plafer plafer merged commit da6653e into main Oct 11, 2022
@plafer plafer deleted the plafer/159-clientstate-not-optional branch October 11, 2022 15:11
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this pull request Nov 4, 2023
* Update changelog

* Bump Rust crate version to v0.10.2
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* Enforce ClientState in Open{Try,Ack}

* fix conn_open_try tests

* fix conn_open_ack tests

* changelog

* ConnOpenConfirm: remove useless check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClientState in MsgConnectionOpenTry must not be optional
2 participants