Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS20: Update createOutgoingPacket name, signature and sendPacket logic #709

Closed
3 tasks
mpoke opened this issue Apr 11, 2022 · 0 comments · Fixed by #750
Closed
3 tasks

ICS20: Update createOutgoingPacket name, signature and sendPacket logic #709

mpoke opened this issue Apr 11, 2022 · 0 comments · Fixed by #750
Assignees
Labels
app Application layer. implementation Tracking an external implementation of the spec.

Comments

@mpoke
Copy link
Contributor

mpoke commented Apr 11, 2022

  • createOutgoingPacket should be renamed to sendTransfer to be consistent with the ibc-go implementation. Plus, the name is currently misleading since the method also sends the packet.
  • remove source, destPort, and destChannel from the signature of createOutgoingPacket since they are not needed (i.e., source is computed in the method, while destPort and destChannel can be queried from the channel end (see the ibc-go implementation).
  • fix sendPacket call to match ICS4.
@mpoke mpoke added app Application layer. implementation Tracking an external implementation of the spec. labels Apr 11, 2022
@mpoke mpoke self-assigned this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Application layer. implementation Tracking an external implementation of the spec.
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

1 participant