ICS4: Simplify sendPacket interface #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the changes are approved, I'll create different PRs for handling the tasks in the description. |
mpoke
added
ready-for-review
cwgoes
approved these changes
May 9, 2022
AdityaSripal
approved these changes
May 10, 2022
colin-axner
approved these changes
May 18, 2022
3 tasks
@colin-axner That's a good point. @AdityaSripal @crodriguezvega what do you think? |
This was referenced May 20, 2022
seantking
approved these changes
May 23, 2022
colin-axner
reviewed
Aug 10, 2022
Comment on lines
+531
to
+537
| function sendPacket( | ||
| capability: CapabilityKey, | ||
| sourcePort: Identifier, | ||
| sourceChannel: Identifier, | ||
| timeoutHeight: Height, | ||
| timeoutTimestamp: uint64, | ||
| data: bytes) { |
There was a problem hiding this comment.
sorry I am just noticing this now, but I think the packet sequence should be returned. This will be useful for UX
There was a problem hiding this comment.
@colin-axner Could you please open an issue?
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #708
Before merging update the calls to sendPacket throughout the standard, i.e.,
createOutgoingPacket(already inconsistent with ICS-4, see ICS20: Update createOutgoingPacket name, signature and sendPacket logic #709)SendTx(already inconsistent with ICS-4)