Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS20: Simplify sendPacket interface #750

Merged
merged 2 commits into from
May 23, 2022
Merged

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented May 20, 2022

Makes ICS20 consistent with #731

Closes #709

@mpoke mpoke added the ready-for-review Pull requests which are ready for review. label May 20, 2022
denomination: string,
amount: uint256,
sender: string,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need sender

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wanted to remove source.

@mpoke mpoke requested a review from AdityaSripal May 23, 2022 16:24
@mpoke mpoke merged commit 136e536 into master May 23, 2022
@mpoke mpoke deleted the marius/ics20-sendpacket-simplify branch May 23, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Pull requests which are ready for review.
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

ICS20: Update createOutgoingPacket name, signature and sendPacket logic
2 participants