Refactors so TableInvoice takes the total fee #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jbibla
previously approved these changes
Jun 28, 2019
|
Will change destination branch to develop once the chrome-extension branch has been merged. |
|
Refactoring TableInvoice accepting BondDenom as a prop based on comment: https://github.com/luniehq/lunie-browser-extension/issues/30#issuecomment-507854375 |
5 tasks
|
The above refactor of TableInvoice was completed in PR #2802 |
jbibla
reviewed
Jul 3, 2019
test/unit/specs/components/ActionModal/components/__snapshots__/TableInvoice.spec.js.snap
Outdated
Show resolved
Hide resolved
jbibla
approved these changes
Jul 4, 2019
jbibla
reviewed
Jul 4, 2019
| @@ -98,8 +98,7 @@ exports[`ActionModal should show the action modal when user has logged in with e | |||
|
|
|||
| <tableinvoice-stub | |||
| amount="0" | |||
| gasestimate="0" | |||
| gasprice="2.5e-8" | |||
| estimatedfee="0" | |||
There was a problem hiding this comment.
when the estimate was 0 before then yes ;)
faboweb
approved these changes
Jul 4, 2019
This was referenced Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28 for the Extension Repo
Description:
Refactors so TableInvoice takes the total fee rather than taking two numbers as props and calculating it there.
Thank you! 🚀
For contributor:
yarn changelogfor a guided process.Files changedin the github PR explorerFor reviewer: