-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching of expensive templates during rendering (trending-tags) #1094
Labels
enhancement
New feature or request
Comments
Thank you for raising this issue, it is very detailed and has provided an improved solution. I will improve it as soon as possible. |
cotes2020
added a commit
that referenced
this issue
Jun 18, 2023
Resolves #1094 Co-authored-by: Jake Kerr <kodafox@gmail.com>
2 tasks
3 tasks
cotes2020
added a commit
that referenced
this issue
Jun 19, 2023
Resolve #1094 and add margin bottom for layout tags Co-authored-by: Jake Kerr <kodafox@gmail.com>
otzslayer
pushed a commit
to otzslayer/otzslayer.github.io
that referenced
this issue
Jun 21, 2023
…otes2020#1098) Resolve cotes2020#1094 and add margin bottom for layout tags Co-authored-by: Jake Kerr <kodafox@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rendering
_includes/trending-tags.html
for site with many tags / posts is quite slow.Description
In an unmodified new repo from the chirpy template, as well as on a fresh checkout of main. Importing a blog with 330 posts including 750 tags the site build takes about 4 minutes timed with
jekyll s --profile
To Reproduce
Create a new chirpy site from the template and place many posts that have tags into the _posts directory.
Desired behavior
It would be nice if templates that are known to produce the same output site-wide could somehow be cached while rendering.
I experimented with the jekyll-include-cache and saw good results.
By adding
jekyll-include-cache
as a plugin and then overriding the _layout & _includes files which reference trending-tags.html I was able to render the same site in ~11 seconds.The diff that produces this faster output
diff generated with this git command
Environment
ruby -v
gem -v
bundle -v
bundle exec jekyll -v
bundle info jekyll-theme-chirpy
Desktop
The text was updated successfully, but these errors were encountered: