Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jekyll-include-cache plugin to reduce build time #1097

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

cotes2020
Copy link
Owner

Type of change

  • Improvement (refactoring and improving code)

Additional context

Resolves #1094

How has this been tested

  • I have run bash ./tools/test (at the root of the project) locally and passed

Resolves #1094

Co-authored-by: Jake Kerr <kodafox@gmail.com>
@cotes2020 cotes2020 merged this pull request into master Jun 18, 2023
@cotes2020 cotes2020 deleted the reduce-build-time branch June 18, 2023 13:00
@jakerr
Copy link
Contributor

jakerr commented Jun 18, 2023

Thanks a lot for the quick turn around!
One thing I noticed trying to use include_cached too broadly is that if the included template references any dynamic data that is different per page but not included in the arguments to include_cached, such as the template referencing post.* it will break the pages since they'll all be sharing a cache. (It's mentioned in the README for that project.)

That's why in my example I limited it to the one expensive template which I know was completely static across the site.

@cotes2020
Copy link
Owner Author

I missed that point, and it seems that I need to modify the previous commit.

@cotes2020 cotes2020 restored the reduce-build-time branch June 18, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caching of expensive templates during rendering (trending-tags)
2 participants