Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaxFileDescriptors setting shouldn't reduce the system defined values #1083

Closed
adamcfraser opened this issue Aug 19, 2015 · 2 comments
Closed

MaxFileDescriptors setting shouldn't reduce the system defined values #1083

adamcfraser opened this issue Aug 19, 2015 · 2 comments
Assignees
@tleyden
Labels
bug
Milestone
1.2.0

Comments

@adamcfraser
Copy link
Collaborator

As discussed on #1080, when Sync Gateway attempts to set MaxFileDescriptors, it shouldn't ever reduce the number of file descriptors - only increase.
@adamcfraser adamcfraser mentioned this issue Aug 19, 2015
Closed
@adamcfraser adamcfraser changed the title MaxFileDesciptors setting shouldn't reduce the system defined values MaxFileDescriptors setting shouldn't reduce the system defined values Aug 21, 2015
@zgramana
Copy link
Contributor

Additional reading: http://www.cyberciti.biz/faq/linux-increase-the-maximum-number-of-open-files/

@zgramana zgramana added this to the 1.2.0 milestone Aug 21, 2015
@tleyden
Copy link
Contributor

tleyden commented Jan 21, 2016

@zgramana I take it this needs to work on Linux, OSX, and Windows?

tleyden pushed a commit that referenced this issue Jan 22, 2016
Fixes #1083 MaxFileDescriptors setting shouldn't reduce the system de…
06f294f 
…fined values

#1083
@tleyden tleyden mentioned this issue Jan 22, 2016
Merged
tleyden pushed a commit that referenced this issue Jan 22, 2016
Fixes #1083 MaxFileDescriptors setting shouldn't reduce the system de…
e712c1a 
…fined values

#1083

Rework based on PR feedback

1. consolidated getSoftFDLimit() and getSoftFDLimitWithCurrent() into single function.
2. pass syscall.Rlimit as parameter instead of individual values
3. fix numbering in comment

#1504
tleyden pushed a commit that referenced this issue Jan 22, 2016
Fixes #1083 MaxFileDescriptors setting shouldn't reduce the system de…
8c2abed 
…fined values

#1083

Rework based on PR feedback

1. consolidated getSoftFDLimit() and getSoftFDLimitWithCurrent() into single function.
2. pass syscall.Rlimit as parameter instead of individual values
3. fix numbering in comment

#1504
adamcfraser added a commit that referenced this issue Jan 22, 2016
@adamcfraser
Merge pull request #1504 from couchbase/feature/issue_1083_max_file_d…
955dd93 
…escriptors

Fixes #1083 MaxFileDescriptors setting shouldn't reduce the system de…
ajres pushed a commit that referenced this issue Jan 26, 2016
Fixes #1083 MaxFileDescriptors setting shouldn't reduce the system de…
7001155 
…fined values

#1083

Rework based on PR feedback

1. consolidated getSoftFDLimit() and getSoftFDLimitWithCurrent() into single function.
2. pass syscall.Rlimit as parameter instead of individual values
3. fix numbering in comment

#1504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tleyden tleyden

Labels
bug
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
3 participants
@tleyden @zgramana @adamcfraser