Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1083 MaxFileDescriptors setting shouldn't reduce the system de… #1504

Merged
merged 1 commit into from
Jan 22, 2016

Conversation

tleyden
Copy link
Contributor

@tleyden tleyden commented Jan 22, 2016

…fined values

#1083

// 1. Only return a value that is HIGHER than the existing soft limit, since
// a very small percentage of users will wanting to be lowering the limit
// based on this configuration.
// 1. Only return a value that is LESS-THAN-OR-EQUAL to the existing hard limit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numbering is stuck at 1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I guess I've gotten too accustomed to github flavored markdown. Good catch.

@tleyden tleyden force-pushed the feature/issue_1083_max_file_descriptors branch from 06f294f to e712c1a Compare January 22, 2016 06:31
tleyden pushed a commit that referenced this pull request Jan 22, 2016
…fined values

#1083

Rework based on PR feedback

1. consolidated getSoftFDLimit() and getSoftFDLimitWithCurrent() into single function.
2. pass syscall.Rlimit as parameter instead of individual values
3. fix numbering in comment

#1504
@tleyden
Copy link
Contributor Author

tleyden commented Jan 22, 2016

Reworked based on feedback and squashed / pushed -f

@tleyden tleyden force-pushed the feature/issue_1083_max_file_descriptors branch from e712c1a to 8c2abed Compare January 22, 2016 06:37
tleyden pushed a commit that referenced this pull request Jan 22, 2016
…fined values

#1083

Rework based on PR feedback

1. consolidated getSoftFDLimit() and getSoftFDLimitWithCurrent() into single function.
2. pass syscall.Rlimit as parameter instead of individual values
3. fix numbering in comment

#1504
…fined values

#1083

Rework based on PR feedback

1. consolidated getSoftFDLimit() and getSoftFDLimitWithCurrent() into single function.
2. pass syscall.Rlimit as parameter instead of individual values
3. fix numbering in comment

#1504
@tleyden tleyden force-pushed the feature/issue_1083_max_file_descriptors branch from 8c2abed to ce9167d Compare January 22, 2016 06:41
adamcfraser added a commit that referenced this pull request Jan 22, 2016
…escriptors

Fixes #1083 MaxFileDescriptors setting shouldn't reduce the system de…
@adamcfraser adamcfraser merged commit 955dd93 into master Jan 22, 2016
@adamcfraser adamcfraser deleted the feature/issue_1083_max_file_descriptors branch January 22, 2016 07:15
ajres pushed a commit that referenced this pull request Jan 26, 2016
…fined values

#1083

Rework based on PR feedback

1. consolidated getSoftFDLimit() and getSoftFDLimitWithCurrent() into single function.
2. pass syscall.Rlimit as parameter instead of individual values
3. fix numbering in comment

#1504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants