CBG-4035: [3.1.9 backport] Skipped Sequence Optimisations #6925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6789) * CBG-3854: Integeration of the skipped sequence slice into the cache * remove old chnages not needed anymore + gh actions failures * updates based of review. Move stat update to updateStats and alter soem naming. Test updates to reflect stat chnages too. * remove incorrect incrementing of num current sequences inside PushSkippedSequenceEntry * Fix race condition in updateStats() * updates off review * tidy CleanSkippedSequenceQueue
* CBG-3850: Optimise releaseUnusedSequenceRange function + support for ranges in pending queue * updates to add _pushRangeToPending and _removeSubsetOfRangeFromSkipped to process duplicates sequences between unused rnage and pending/skipped lists * fix race condition in test * fix for incorrect logic for removing skipped range * updates based off review * updates to fix incorrect code + add extra test coverage of changes * change error name
adamcfraser
approved these changes
Jul 9, 2024
bbrks
added a commit
that referenced
this pull request
Nov 11, 2024
1 task
bbrks
added a commit
that referenced
this pull request
Nov 11, 2024
* Revert "CBG-4218 [3.1.11 backport] Move duplicate checks for pending sequences to read side (#7105)" This reverts commit b6127c1. * Revert "CBG-4221 [3.1.11 backport] Don't increment high sequence cached for unused sequences on pendingLogs (#7106)" This reverts commit 5ba7cd0. * Revert "CBG-4035: [3.1.9 backport] Skipped Sequence Optimisations (#6925)" This reverts commit ea40269. * Re-add tests
bbrks
added a commit
that referenced
this pull request
Jan 29, 2025
adamcfraser
pushed a commit
that referenced
this pull request
Jan 29, 2025
…ith later optimisations applied (#7330) * Revert "CBG-4218 [3.1.11 backport] Move duplicate checks for pending sequences to read side (#7105)" This reverts commit b6127c1. * Revert "CBG-4221 [3.1.11 backport] Don't increment high sequence cached for unused sequences on pendingLogs (#7106)" This reverts commit 5ba7cd0. * Revert "CBG-4035: [3.1.9 backport] Skipped Sequence Optimisations (#6925)" This reverts commit ea40269. * Re-add tests * Restore stats and deprecate them * CBG-4360: Add uinx timestamp to skipped list entry (#7193) * Undeprecate Go code because linter is too strict but deprecate the actual stat definition for external users * remove unnecessary type conversion * Deprecate existing stat and keep NumCurrentSeqsSkipped --------- Co-authored-by: Gregory Newman-Smith <109068393+gregns1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4035
All optimisations for skipped sequences
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2555/