check browser after checking for hashchange #47
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery 1.9 removed support for
$.browser
in favor of solutions like Modernizr. This produces the following error in ChromeWhile moving to Modernizr would make sense, this simple fix is enough for most that run into this. In my case I do not need support for Internet Explorer 6, 7, or 8 so I am using jQuery 2 which removed that support. Because I am only supporting browsers which support the
hashchange
event, moving the call to$.browser
means it is never executed due to short-circuit evaluation.