-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$.browser is undefined #42
Comments
I got that issue too, and followed this fix:
I found it here: https://drupal.org/node/1961178 |
This is likely due to $.browser being removed in jquery 1.9. http://api.jquery.com/jquery.browser/ |
@msmuenchen It's not likely, it's definately ;) |
@MxrBlind I'm not sure checking for IE6 specifically is enough. The fallback is needed for IE7 and IE8 as well, iirc. Otoh, jQuery is about to drop IE6&7 support fairly soon, a so check for IE8 only might prove sufficient in the near future. |
Short term solution like "if ($.browser && ..." ? |
Yeah, if you leave issues be for long enough, they will disspear by themselves. In this case, the whole hashchange plugin has become obsolete now they many folks are supporting IE 9 and up. Here's an idea: check jQuery version. Folks using jQuery 2.x will not be supporting IE8 and lower, so when jQuery 2.x is loaded, skip everything. When 1.x is loaded, do whatever Modernizr does. |
Fixes cowboy#42 Ideally we'd improve the feature test to not need this but looks like we still need it for IE6/7 which pass the feature test but do need this override in order to work properly.
so what we can do?? Don't always use jquery version low 1.9 or use jquery migrate plugs ?? I think bast way is change origin code |
Just don't use this plugin and use the native hashchange event. With many of our projects supporting no MSIE at all, the need for IE-specific code has gone down the toilet. Microsoft has deemed MSIE deprecated as well, in favour of Edge. And so should you. |
This should be the first line of the README. |
I'm getting this error:
Hashchange 1.3
jQuery 2.1.0
Firefox 27 (this won't matter, but just for completeness)
I think the error speaks for itself.
The text was updated successfully, but these errors were encountered: