Use of deprecated $.browser

[jonathanKingston]

Preconditions (*)

Steps to reproduce (*)

1. git grep "$.browser"

Expected result (*)

1. No use of $.browser

Actual result (*)

app/code/Magento/Checkout/view/frontend/web/js/model/step-navigator.js:                bodyElem = $.browser.safari || $.browser.chrome ? $('body') : $('html');
app/code/Magento/Swagger/view/frontend/web/swagger-ui/js/lib/jquery.ba-bbq.min.js:(function($,i,b){var j,k=$.event.special,c="location",d="hashchange",l="href",f=$.browser,g=document.documentMode,h=f.msie&&(g===b||g<8),e="on"+d in i&&!h;function a(m){m=m||i[c][l];return m.replace(/^[^#]*#?(.*)$/,"$1")}$[d+"Delay"]=100;k[d]=$.extend(k[d],{setup:function(){if(e){return false}$(j.start)},teardown:function(){if(e){return false}$(j.stop)}});j=(function(){var m={},r,n,o,q;function p(){o=q=function(s){return s};if(h){n=$('<iframe src="javascript:0"/>').hide().insertAfter("body")[0].contentWindow;q=function(){return a(n.document[c][l])};o=function(u,s){if(u!==s){var t=n.document;t.open().close();t[c].hash="#"+u}};o(a())}}m.start=function(){if(r){return}var t=a();o||p();(function s(){var v=a(),u=q(t);if(v!==t){o(t=v,u);$(i).trigger(d)}else{if(u!==t){i[c][l]=i[c][l].replace(/#.*/,"")+"#"+u}}r=setTimeout(s,$[d+"Delay"])})()};m.stop=function(){if(!n){r&&clearTimeout(r);r=0}};return m})()})(jQuery,this);
lib/web/jquery/jquery.ba-hashchange.min.js:(function($,e,b){var c="hashchange",h=document,f,g=$.event.special,i=h.documentMode,d="on"+c in e&&(i===b||i>7);function a(j){j=j||location.href;return"#"+j.replace(/^[^#]*#?(.*)$/,"$1")}$.fn[c]=function(j){return j?this.bind(c,j):this.trigger(c)};$.fn[c].delay=50;g[c]=$.extend(g[c],{setup:function(){if(d){return false}$(f.start)},teardown:function(){if(d){return false}$(f.stop)}});f=(function(){var j={},p,m=a(),k=function(q){return q},l=k,o=k;j.start=function(){p||n()};j.stop=function(){p&&clearTimeout(p);p=b};function n(){var r=a(),q=o(m);if(r!==m){l(m=r,q);$(e).trigger(c)}else{if(q!==m){location.href=location.href.replace(/#.*/,"")+q}}p=setTimeout(n,$.fn[c].delay)}$.browser.msie&&!d&&(function(){var q,r;j.start=function(){if(!q){r=$.fn[c].src;r=r&&r+a();q=$('<iframe tabindex="-1" title="empty"/>').hide().one("load",function(){r||l(a());n()}).attr("src",r||"javascript:0").insertAfter("body")[0].contentWindow;h.onpropertychange=function(){try{if(event.propertyName==="title"){q.document.title=h.title}}catch(s){}}}};j.stop=k;o=function(){return a(q.location.href)};l=function(v,s){var u=q.document,t=$.fn[c].domain;if(v!==s){u.title=h.title;u.open();t&&u.write('<script>document.domain="'+t+'"<\/script>');u.close();q.location.hash=v}}})();return j})()})(jQuery,this);
lib/web/jquery/jstree/jquery.jstree.js:         // code is copied from jQuery ($.browser is deprecated + there is a bug in IE)
lib/web/mage/popup-window.js:                if ($.browser.msie) { // Hacked together for IE browsers

Reopening from: #13799 this is deprecated and still exists in the core, it doesn't look like the hacky usages are needed any more either.

Only lib/web/mage/popup-window.js and app/code/Magento/Checkout/view/frontend/web/js/model/step-navigator.js are actual non lib usage which are old commits (ignoring refactoring etc).

[jonathanKingston]

Looks like jQuery hashchange is no longer needed for IE9+ support: cowboy/jquery-hashchange#42

[magento-engcom-team]

@jonathanKingston, thank you for your report.
We've acknowledged the issue and added to our backlog.

[sidolov]

Hi @jonathanKingston. Thank you for your report.
The issue has been fixed in #14270 by @jonathanKingston in 2.3-develop branch
Related commit(s):

• 6c46def154a3c43cc9a9f7518761e7ed09dc71a3

The fix will be available with the upcoming 2.3.0 release.

[csdougliss]

@osrecio @kirmorozov Was this fixed in 2.3.0 ? I still get it.

[jaxtheking]

I can confirm I also get this error on most pages in the BO.

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

Hi @jonathanKingston thank you for your report. I am not able to reproduce issue by steps you described on 2.3-develop
I got only one usage of $.browser in comment:
lib/web/jquery/jstree/jquery.jstree.js: // code is copied from jQuery ($.browser is deprecated + there is a bug in IE)

If you'd like to update the issue, please reopen it.