feat: Add optional chaining to the babel preset #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drazik
approved these changes
Feb 15, 2019
ptbrowne
approved these changes
Feb 18, 2019
[Optional chaining](https://github.com/tc39/proposal-optional-chaining) allows to chain potentially null components. Instead of doing ``` if (window && window.location && window.location.protocol) { ssl = window.location.protocol } ``` we could do ``` ssl = window?.location?.protocol ``` The spec is stage 1 only but [they seem to have reach consensus](tc39/proposal-optional-chaining#75 (comment)) and [the formal stage 2 decision should be in March](tc39/proposal-optional-chaining#76 (comment)) There should not be any compatibility break
edas
force-pushed
the
feat/optional-chaining
branch
from
b7b005e to
461ce42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional chaining
allows to chain potentially null components.
Instead of doing
we could do
The spec is stage 1 only but they seem to have reach consensus
and the formal stage 2 decision should be in March
There should not be any compatibility break