Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Revert previous spec alterations #75

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Revert previous spec alterations #75

merged 2 commits into from
Nov 30, 2018

Conversation

dusave
Copy link
Member

@dusave dusave commented Nov 29, 2018

Based on a breakout session and laying out all aspects of this proposal, I believe we have reached a positive conclusion and have broad agreement on the entirety of this proposal.

@dusave dusave mentioned this pull request Nov 29, 2018
@mAAdhaTTah
Copy link

have broad agreement on the entirety of this proposal.

Does this include the token?

@dusave
Copy link
Member Author

dusave commented Nov 29, 2018

@mAAdhaTTah That includes the proposed token. Not all like it, but we agree it's the best of the presented options and it will not be blocked on that when seeking stage advancement.

@jackkoppa
Copy link

@dustinsavery, that's fantastic! Thank you for advocating for this. Does that breakout section, and the spec as it will now stand, make you fully optimistic about the March conference Stage 2 proposal?

@dusave
Copy link
Member Author

dusave commented Nov 29, 2018

I'm pretty optimistic now, yes! But given the history, I'm also cautious. People could forget why they were in support of it in 4 months 😄

@hax
Copy link
Member

hax commented Nov 30, 2018

@dustinsavery Could I ask what's the proposed tokens now?

@Zarel
Copy link

Zarel commented Nov 30, 2018

@hax Just look at the "Files changed" tab. It's being restored to the original proposal:

obj?.prop       // optional static property access
obj?.[expr]     // optional dynamic property access
func?.(...args) // optional function or method call

(I'm pretty happy with this one; it's overwhelmingly the most popular option, and the only option that had a positive vote total in the poll.)

@dusave dusave merged commit e8c8c60 into master Nov 30, 2018
@dusave dusave deleted the revert branch November 30, 2018 04:21
@ljharb ljharb mentioned this pull request Dec 1, 2018
edas added a commit to cozy/cozy-libs that referenced this pull request Feb 15, 2019
[Optional chaining](https://github.com/tc39/proposal-optional-chaining)
allows to chain potentially null components.

Instead of doing
```
if (window && window.location && window.location.protocol) {
  ssl = window.location.protocol
}
```
we could do
```
ssl = window?.location?.protocol
```

The spec is stage 1 only but [they seem to have reach consensus](tc39/proposal-optional-chaining#75 (comment))
and [the formal stage 2 decision should be in March](tc39/proposal-optional-chaining#76 (comment))

There should not be any compatibility break
edas added a commit to cozy/cozy-libs that referenced this pull request Feb 18, 2019
[Optional chaining](https://github.com/tc39/proposal-optional-chaining)
allows to chain potentially null components.

Instead of doing
```
if (window && window.location && window.location.protocol) {
  ssl = window.location.protocol
}
```
we could do
```
ssl = window?.location?.protocol
```

The spec is stage 1 only but [they seem to have reach consensus](tc39/proposal-optional-chaining#75 (comment))
and [the formal stage 2 decision should be in March](tc39/proposal-optional-chaining#76 (comment))

There should not be any compatibility break
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants