For #452: Added LCOM4 report #458
Conversation
|
This pull request #458 is assigned to @Vatavuk/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job |
| @@ -200,6 +200,14 @@ public void analyze() throws IOException { | |||
| ) | |||
| ); | |||
| } | |||
| if (this.params.containsKey("LCOM4")) { | |||
There was a problem hiding this comment.
@paulodamaso analyze is a really long method. How about we extract reports building to a separate class and use a Map instead of if statements? In that sense we can localize future changes in that class not in the main method.
|
@Vatavuk Yes, you are right, I've added a puzzle for that, please take a look |
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 10min) |
|
@paulodamaso please remove this issue from the scope |
|
@0crat out |
|
Job was finished in 47 hours, bonus for fast delivery is possible (see §36) |
|
@sereshqua/z please review this job completed by @Vatavuk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
@Vatavuk please make sure you will find at least 3 issues during next CR, thanks |
|
@sereshqua ok |
|
@0crat quality acceptable |
For #452:
LCOM4report toMain.javaREADME.md