Propagate the suppression of tf warnings #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
|
Thanks for this. Test failures are unrelated to this change, so merging. |
ayrton04
reviewed
Nov 17, 2021
| @@ -287,6 +287,10 @@ class NavSatTransform | |||
| //! | |||
| ros::Duration transform_timeout_; | |||
|
|
|||
| //! @brief When true, do not print warnings for tf lookup failures. | |||
| //! | |||
| bool tf_silent_failure_; | |||
There was a problem hiding this comment.
Actually, sorry, small request: can we put this up with the other booleans? My original aim here was to group variables by data type and then alphabetically, though I realise there are some variables that don't adhere to that standard here.
| @@ -638,6 +638,10 @@ template<class T> class RosFilter | |||
| //! | |||
| ros::Duration tfTimeout_; | |||
|
|
|||
| //! @brief When true, do not print warnings for tf lookup failures. | |||
| //! | |||
| bool tfSilentFailure_; | |||
There was a problem hiding this comment.
Same thing here, if you don't mind.
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
|
@ayrton04, I think this should be good to go. Do you mind to review it again? Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch propagates the suppression of
tfwarnings to all places where there's alookupTransformSafe().Signed-off-by: Carlos Agüero caguero@openrobotics.org