Clear all lines during Interject_with #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have rebased this PR. Is there anything I should do to get this merged ? |
|
This would be a useful bug fix to include, I have encountered the same issue in my use of progress. |
|
Ping ? This one bug has been preventing me from using |
|
cc @craigfe |
|
It seems right, I've also observed your behaviour and this patch should correct it. I'm going to integrate this PR but we're definitely lacking tests that can help us better specify the behaviour of progress. |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Apr 13, 2024
CHANGES: - Be compatible with MirageOS and remove `ocaml_terminal_get_sigwinch` (@art-w, craigfe/progress#38) - Clear all lines in `interject_with` (@Gbury, craigfe/progress#30) - Add `Display.remove_line` (@mbarbin, craigfe/progress#26) - Fix compilation for OCaml 5.2 (reported by @Gbury, fixed by @dinosaure, craigfe/progress#40) - Add `Display.{pause,resume}` (@Gbury, craigfe/progress#37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #29 .
After looking a bit at the code, it seems like the code for interject_with only clears the line once, after moving up, so it effectively only clears the topmost line. This PR tries to clear all the lines, by clearing the current line, and then moving up, one line at a time.
On my example, it seems to fix the problem.