Fix the compilation on 5.2.0~alpha1 about our inlined tag #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… attribute It seems that this code try to optimize the way we manipulate `Mtime.t` values. However, OCaml is not able to do cross-module optimisation: [@@inlined] has no incidence in the assembler generated (tested with 4.14 and 5.0). This patch remove the overlooked optimisation and be compatible with the next release of OCaml 5.2. .
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Apr 13, 2024
CHANGES: - Be compatible with MirageOS and remove `ocaml_terminal_get_sigwinch` (@art-w, craigfe/progress#38) - Clear all lines in `interject_with` (@Gbury, craigfe/progress#30) - Add `Display.remove_line` (@mbarbin, craigfe/progress#26) - Fix compilation for OCaml 5.2 (reported by @Gbury, fixed by @dinosaure, craigfe/progress#40) - Add `Display.{pause,resume}` (@Gbury, craigfe/progress#37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.