v2.5.0 Release (#524)

## _v2.5.0 (20180919)_

**[Bug Fixes]**
- Fix HTML menu error for GICABLE in IRMQTTServer. (#516)
- Fix Mitsubishi A/C mode setting. (#514)
- Add missing ',' in auto analyse tool generated code. (#513)
- Fix Fujitsu checksum validation. (#501)
- Remove errant Repeat debug statement in IRMQTTServer. (#507)

**[Features]**
- Mitsubishi A/C decode improvements. (#514)
- Basic support for Whirlpool A/C messages. (#511)
- Basic support for Samsung A/C messages. (#512)
- Experimental support for detailed Samsung A/C messages. (#521)
- Experimental support for detailed Coolix A/C messages. (#518)
- Experimental support for Lutron protocol. (#516)
- Calculate and use average values for timings in analysing tool. (#513)

**[Misc]**
- Style change from using `#define`s for constants to `const kConstantName`.
- Improve the JVC example code.

.github/Contributors.md

@@ -10,6 +10,7 @@
 - [Jonny Graham](https://github.com/jonnygraham/)
 - [Stu Fisher](https://github.com/stufisher/)
 - [Jorge Cisneros](https://github.com/jorgecis/)
+- [Denes Varga](https://github.com/denxhun/)
 
 All contributors can be found on the [contributors site](https://github.com/markszabo/IRremoteESP8266/graphs/contributors). 
 

.gitignore

@@ -40,3 +40,6 @@ tools/gc_decode
 .piolibdeps
 .clang_complete
 .gcc-flags.json
+
+#Cygwin builds
+*.exe

README.md

@@ -7,12 +7,27 @@
 
 This library enables you to **send _and_ receive** infra-red signals on an [ESP8266 using the Arduino framework](https://github.com/esp8266/Arduino) using common 940nm IR LEDs and common IR receiver modules. e.g. TSOP{17,22,24,36,38,44,48}* etc.
 
-## v2.4.3 Now Available
-Version 2.4.3 of the library is now [available](https://github.com/markszabo/IRremoteESP8266/releases/latest). You can view the [Release Notes](ReleaseNotes.md) for all the significant changes.
+## v2.5.0 Now Available
+Version 2.5.0 of the library is now [available](https://github.com/markszabo/IRremoteESP8266/releases/latest). You can view the [Release Notes](ReleaseNotes.md) for all the significant changes.
 
 #### Upgrading from pre-v2.0
 Usage of the library slight changed at v2.0. You will need to change your usage to work with v2.0 and beyond. You can read more about the changes required on our [Upgrade to v2.0](https://github.com/markszabo/IRremoteESP8266/wiki/Upgrading-to-v2.0) page.
 
+#### Upgrading from pre-v2.5
+The library has changed from using constants declared as `#define` to
+[const](https://google.github.io/styleguide/cppguide.html#Constant_Names) with
+the appropriate naming per the
+[C++ style guide](https://google.github.io/styleguide/cppguide.html).
+This may potentially cause old programs to not compile.
+The most likely externally used `#define`s have been _aliased_ for limited
+backward compatibility for projects using the old style. Going forward, only the
+new `kConstantName` style will be supported for new protocol additions.
+
+In the unlikely case it does break your code, then you may have been referencing
+something you likely should not have. You should be able to quickly determine
+the new name from the old. e.g. `CONSTANT_NAME` to `kConstantName`.
+Use common sense or examining the library's code if this does affect code.
+
 ## Troubleshooting
 Before reporting an issue or asking for help, please try to follow our [Troubleshooting Guide](https://github.com/markszabo/IRremoteESP8266/wiki/Troubleshooting-Guide) first.
 

ReleaseNotes.md

@@ -1,5 +1,28 @@
 # Release Notes
 
+## _v2.5.0 (20180919)_
+
+**[Bug Fixes]**
+- Fix HTML menu error for GICABLE in IRMQTTServer. (#516)
+- Fix Mitsubishi A/C mode setting. (#514)
+- Add missing ',' in auto analyse tool generated code. (#513)
+- Fix Fujitsu checksum validation. (#501)
+- Remove errant Repeat debug statement in IRMQTTServer. (#507)
+
+**[Features]**
+- Mitsubishi A/C decode improvements. (#514)
+- Basic support for Whirlpool A/C messages. (#511)
+- Basic support for Samsung A/C messages. (#512)
+- Experimental support for detailed Samsung A/C messages. (#521)
+- Experimental support for detailed Coolix A/C messages. (#518)
+- Experimental support for Lutron protocol. (#516)
+- Calculate and use average values for timings in analysing tool. (#513)
+
+**[Misc]**
+- Style change from using #define's for constants to `const kConstantName`.
+- Improve the JVC example code.
+
+
 ## _v2.4.3 (20180727)_
 
 **[Bug Fixes]**

examples/IRGCTCPServer/IRGCTCPServer.ino

@@ -9,7 +9,7 @@
  * For more codes, visit: https://irdb.globalcache.com/
  *
  * How to use this program:
- *   1) Update "ssid" and "password" below for your WIFI network.
+ *   1) Update "kSsid" and "kPassword" below for your WIFI network.
  *   2) Compile and upload the sketch to your ESP8266 module.
  *   3) (Optional) Use the serial connection to confirm it started and get the
  *      IP address.
@@ -46,8 +46,8 @@
 #include <WiFiClient.h>
 #include <WiFiServer.h>
 
-const char* ssid = "...";  // Put your WIFI SSID here.
-const char* password = "...";  // Put your WIFI password here.
+const char* kSsid = "...";  // Put your WIFI SSID here.
+const char* kPassword = "...";  // Put your WIFI Password here.
 
 WiFiServer server(4998);  // Uses port 4998.
 WiFiClient client;
@@ -103,7 +103,7 @@ void setup() {
   delay(100);
   Serial.println(" ");
   Serial.println("IR TCP Server");
-  WiFi.begin(ssid, password);
+  WiFi.begin(kSsid, kPassword);
   while (WiFi.status() != WL_CONNECTED) {
     delay(900);
     Serial.print(".");