Basic support for Samsung A/C messages. #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @Hollako I've made the following assumptions:
|
- Basic send and decode support. i.e. No detailed breakdown/construction. - Unit tests. - IRMQTTServer example code updated to support this. - Placeholder for upcoming Whirlpool A/C support. Ref: #505
crankyoldgit
force-pushed
the
v2.5-dev-samsung-ac
branch
from
860858d to
c0bd992
Compare
|
No negative feedback received after 7 days. Merging. |
crankyoldgit
added a commit
that referenced
this pull request
Sep 20, 2018
## _v2.5.0 (20180919)_ **[Bug Fixes]** - Fix HTML menu error for GICABLE in IRMQTTServer. (#516) - Fix Mitsubishi A/C mode setting. (#514) - Add missing ',' in auto analyse tool generated code. (#513) - Fix Fujitsu checksum validation. (#501) - Remove errant Repeat debug statement in IRMQTTServer. (#507) **[Features]** - Mitsubishi A/C decode improvements. (#514) - Basic support for Whirlpool A/C messages. (#511) - Basic support for Samsung A/C messages. (#512) - Experimental support for detailed Samsung A/C messages. (#521) - Experimental support for detailed Coolix A/C messages. (#518) - Experimental support for Lutron protocol. (#516) - Calculate and use average values for timings in analysing tool. (#513) **[Misc]** - Style change from using #define's for constants to `const kConstantName`. - Improve the JVC example code.
Merged
crankyoldgit
added a commit
that referenced
this pull request
Sep 20, 2018
## _v2.5.0 (20180919)_ **[Bug Fixes]** - Fix HTML menu error for GICABLE in IRMQTTServer. (#516) - Fix Mitsubishi A/C mode setting. (#514) - Add missing ',' in auto analyse tool generated code. (#513) - Fix Fujitsu checksum validation. (#501) - Remove errant Repeat debug statement in IRMQTTServer. (#507) **[Features]** - Mitsubishi A/C decode improvements. (#514) - Basic support for Whirlpool A/C messages. (#511) - Basic support for Samsung A/C messages. (#512) - Experimental support for detailed Samsung A/C messages. (#521) - Experimental support for detailed Coolix A/C messages. (#518) - Experimental support for Lutron protocol. (#516) - Calculate and use average values for timings in analysing tool. (#513) **[Misc]** - Style change from using `#define`s for constants to `const kConstantName`. - Improve the JVC example code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #505