Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IRMQTTServer small mistake #596

Closed
jimmys01 opened this issue Jan 11, 2019 · 2 comments
Closed

IRMQTTServer small mistake #596

jimmys01 opened this issue Jan 11, 2019 · 2 comments
Assignees
@crankyoldgit
Labels
bug

Comments

@jimmys01
Copy link
Contributor

in your IRMQTTServer.ino change those
#if MITSUBISHI_AC
case MITSUBISHI_AC:
to
#if SEND_MITSUBISHI_AC
case MITSUBISHI_AC:

from ESPEasy #2230
@crankyoldgit crankyoldgit self-assigned this Jan 11, 2019
crankyoldgit added a commit that referenced this issue Jan 11, 2019
@crankyoldgit
[BUG] Enum used instead of #define for Mitsubishi A/C.
bb566af 
Originally reported in letscontrolit/ESPEasy#2230

Fixes #596
@crankyoldgit
Copy link
Owner

@jimmys01 Thanks for reporting it. I'll merge the fix as soon as the CI/Travis checks are finished.

(Ref: letscontrolit/ESPEasy#2230)

crankyoldgit added a commit that referenced this issue Jan 11, 2019
@crankyoldgit
[BUG] Fix incorrect #define usage.
24d3599 
Originally reported in letscontrolit/ESPEasy#2230

MITSUBISHI_AC -> SEND_MITSUBISHI_AC
SEND_MWM_ -> SEND_MWM

Fixes #596
@crankyoldgit crankyoldgit mentioned this issue Jan 11, 2019
Merged
crankyoldgit added a commit that referenced this issue Jan 11, 2019
@crankyoldgit
[BUG] Fix incorrect #define usage. (#597)
c6d7bdb 
Originally reported in letscontrolit/ESPEasy#2230

MITSUBISHI_AC -> SEND_MITSUBISHI_AC
SEND_MWM_ -> SEND_MWM

Fixes #596
crankyoldgit added a commit that referenced this issue Feb 7, 2019
@crankyoldgit
v2.5.5 release
33425fb 
_v2.5.5 (20190207)_

**[Bug Fixes]**
- Fix decoding of Samsung A/C Extended messages. (#610)
- Fix IRMQTTServer example to work with GPIO0 as IR_RX (#608)
- Fix incorrect #define usage. (#597, #596)

**[Features]**
- Add deep decoding/construction of Daikin2 messages (#600)
- Added Old Vestel A/C support (56 Bits) with full functions. (#607)

**[Misc]**
- Add ControlSamsungAC example code. (#599)
- Add how to send a state/air-con to IRsendDemo.ino (#594)
@crankyoldgit crankyoldgit mentioned this issue Feb 7, 2019
Merged
crankyoldgit added a commit that referenced this issue Feb 7, 2019
@crankyoldgit
v2.5.5 release (#615)
812f899 
_v2.5.5 (20190207)_

**[Bug Fixes]**
- Fix decoding of Samsung A/C Extended messages. (#610)
- Fix IRMQTTServer example to work with GPIO0 as IR_RX (#608)
- Fix incorrect #define usage. (#597, #596)

**[Features]**
- Add deep decoding/construction of Daikin2 messages (#600)
- Added Old Vestel A/C support (56 Bits) with full functions. (#607)

**[Misc]**
- Add ControlSamsungAC example code. (#599)
- Add how to send a state/air-con to IRsendDemo.ino (#594)
@crankyoldgit
Copy link
Owner

This has been included in the new v2.5.5 release of the library.

Repository owner locked as resolved and limited conversation to collaborators Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crankyoldgit crankyoldgit

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crankyoldgit @jimmys01