Fix IRMQTTServer example to work with GPIO0 as IR_RX #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! Thanks very much for the PR/fix. I'm sorry it caused you grief. That would have been pain to debug. :-( |
crankyoldgit
added a commit
that referenced
this pull request
Feb 7, 2019
_v2.5.5 (20190207)_ **[Bug Fixes]** - Fix decoding of Samsung A/C Extended messages. (#610) - Fix IRMQTTServer example to work with GPIO0 as IR_RX (#608) - Fix incorrect #define usage. (#597, #596) **[Features]** - Add deep decoding/construction of Daikin2 messages (#600) - Added Old Vestel A/C support (56 Bits) with full functions. (#607) **[Misc]** - Add ControlSamsungAC example code. (#599) - Add how to send a state/air-con to IRsendDemo.ino (#594)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Feb 7, 2019
_v2.5.5 (20190207)_ **[Bug Fixes]** - Fix decoding of Samsung A/C Extended messages. (#610) - Fix IRMQTTServer example to work with GPIO0 as IR_RX (#608) - Fix incorrect #define usage. (#597, #596) **[Features]** - Add deep decoding/construction of Daikin2 messages (#600) - Added Old Vestel A/C support (56 Bits) with full functions. (#607) **[Misc]** - Add ControlSamsungAC example code. (#599) - Add how to send a state/air-con to IRsendDemo.ino (#594)
|
This has been included in the new v2.5.5 release of the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After hours of debugging, I have finally found why my receiver does not work, and I would like to save the next poor guy's time 😄