Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Travis to GitHub Actions #1526

Merged
merged 18 commits into from
Jul 10, 2021
Merged

Migrate from Travis to GitHub Actions #1526

merged 18 commits into from
Jul 10, 2021

Conversation

crankyoldgit
Copy link
Owner

@crankyoldgit crankyoldgit commented Jul 7, 2021

  • Move any remaining Travis processes to GitHub Actions
  • Remove Travis files and references. (Excluding ReleaseNotes.md)
  • Change badges as well.
    • Remove two defunct badges.
    • Add a badge per GitHub Actions workflow.

Fixes #1522

These are being run as GitHub actions. Reduce stuff running on Travis

For #1522
@crankyoldgit
Copy link
Owner Author

@NiKiZe Hold ya horses! I hadn't added you as a reviewer yet. I'm still working on this. ;-)
In order for the Github Actions etc to trigger/run I had to create a PR.
As I work to clean this up/improve etc, I'll be adding more and more. Some will work. Some will fail.

I'll let you know when it's ready to review! ;-)

@NiKiZe
Copy link
Collaborator

NiKiZe commented Jul 7, 2021

Is there any way to cache platformio compiles to reduce time spent? Seeing the output the same files are compiled multiple times?

@crankyoldgit
Copy link
Owner Author

Is there any way to cache platformio compiles to reduce time spent? Seeing the output the same files are compiled multiple times?

Yes, and it is set up to do that. If the compile/build options are the same, it does cache them.

However, a lot of the "duplication" is due to different compiler flags being used. e.g. A build with -D_IR_LOCALE_=en-AU, then a build with -D_IR_LOCALE_=de-DE. When that happens, it can't cache the files. :-(

@crankyoldgit
Copy link
Owner Author

Is there any way to cache platformio compiles to reduce time spent? Seeing the output the same files are compiled multiple times?

Yes, and it is set up to do that. If the compile/build options are the same, it does cache them.

However, a lot of the "duplication" is due to different compiler flags being used. e.g. A build with -D_IR_LOCALE_=en-AU, then a build with -D_IR_LOCALE_=de-DE. When that happens, it can't cache the files. :-(

Well, let's just say, that's what it was doing under Travis, I haven't got this Github Actions stuff sorted yet.

* Make a workflow for linters
* PlatformIO workflow now does all the examples.
  - Try to improve caching.
* Try to improve UnitTest speed by "-j 2" for Make.
* Remove the moved stuff from Travis

For #1526
* Remove moved checks from Travis
* Cleanup & improvement to Library Linter workflow.
* Doxygen check moved to github workflow.
* No more travis checks, so remove file.
* Move from Travis to the new GitHub Workflows.
* Remove old non-updating badges.

For #1522
* Cut & paste fail. Fixed.
* Add to FR and DE files.

For #1522
Turns out the status badges use these to name the badges. So pick ones we'd like to see in the badges.

For #1522
@NiKiZe
Copy link
Collaborator

NiKiZe commented Jul 8, 2021

There is no risk of running out of free credits for these actions?

@crankyoldgit
Copy link
Owner Author

There is no risk of running out of free credits for these actions?

They don't seem to have a quota system, for the free/public tier. So ... dunno.

* Make the workflow `.yml` file names more consistent.
* Remove references to Travis.
@crankyoldgit crankyoldgit changed the title Migrate more tasks from Travis to GitHub Actions Migrate from Travis to GitHub Actions Jul 8, 2021
@crankyoldgit crankyoldgit requested a review from NiKiZe July 8, 2021 12:05
@crankyoldgit
Copy link
Owner Author

Okay @NiKiZe this PR is done I think. Feel free to review it. ;-)

@crankyoldgit
Copy link
Owner Author

There is no risk of running out of free credits for these actions?

Just double checked. Scroll down a fair bit on https://github.com/features/actions. It's "Free" for Open Source. ;-) <phew>

Copy link
Collaborator

@NiKiZe NiKiZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

README.md Show resolved Hide resolved
.github/workflows/UnitTests.yml Show resolved Hide resolved
@NiKiZe
Copy link
Collaborator

NiKiZe commented Jul 9, 2021

There is no risk of running out of free credits for these actions?

Just double checked. Scroll down a fair bit on https://github.com/features/actions. It's "Free" for Open Source. ;-)

It only mentions private repos (to my eyes) ... the Free part was

to big

@NiKiZe
Copy link
Collaborator

NiKiZe commented Jul 9, 2021

Any chance we can limit number of languages built? Or maybe build everything in order of language instead?

@crankyoldgit
Copy link
Owner Author

Any chance we can limit number of languages built? Or maybe build everything in order of language instead?

Agreed. We need to do something better.
I'd prefer if they were only run/compiled when the locale stuff changed our for a release.

I don't know how to enact that yet.

- Caught in code review.
@crankyoldgit crankyoldgit merged commit c71a150 into master Jul 10, 2021
@crankyoldgit crankyoldgit deleted the ci-changes branch July 21, 2021 13:29
crankyoldgit added a commit that referenced this pull request Aug 28, 2021
_v2.7.20 (20210828)_

**[Bug Fixes]**
- Make `strToSwingH()` match "Right Max" (#1550 #1551)

**[Features]**
- Experimental Bose remote support (#1579)
- Added MitsubishiAC VaneLeft (#1572 #1576)
- HAIER_AC176: Add experimental detailed support (#1480 #1571)
- Detailed support for Tornado/Sanyo 88-bit A/C protocol (#1503 #1568)
- Add support for new `TROTEC_3550` A/C protocol (#1563 #1566 #1507)
- SamsungAc: Use `sendExtended()` going forward. (#1484 #1562)
- SamsungAc: Redo/fix checksum calculations. (#1538 #1554)
- LG: Add support for `AKB73757604` model (#1531 #1545)
- Daikin176: Add support for Unit Id. (#1543 #1544)
- Daikin2: Add support for Humidity setting/operation. (#1535 #1540)
- TCL112AC: Add support for quiet/mute setting. (#1528 #1529)
- LG2: Add Fan speed, Swing, & Light support for new `AKB74955603` model (#1513 #1530)
- Add Mitsubishi AC "fan only" mode (#1527)

**[Misc]**
- Fix pylint issues due to pylint update. (#1569 #1570)
- DAIKIN216: Update supported models. (#1552 #1567)
- IRMQTTServer: Build a minimal OTA image via PlatformIO. (#1513 #1541)
- Reduce memory fragmentation cause by String usage. (#1493 #1536)
- Refactor `decodeMitsubishiAC()` (#1523 #1532)
- Fix incorrect comment.
- Migrate from Travis to GitHub Actions (#1522 #1526)
- Documentation update with additional supported Panasonic AC models (#1525)
@crankyoldgit crankyoldgit mentioned this pull request Aug 28, 2021
crankyoldgit added a commit that referenced this pull request Aug 28, 2021
_v2.7.20 (20210828)_

**[Bug Fixes]**
- Make `strToSwingH()` match "Right Max" (#1550 #1551)

**[Features]**
- Experimental Bose remote support (#1579)
- Added MitsubishiAC VaneLeft (#1572 #1576)
- HAIER_AC176: Add experimental detailed support (#1480 #1571)
- Detailed support for Tornado/Sanyo 88-bit A/C protocol (#1503 #1568)
- Add support for new `TROTEC_3550` A/C protocol (#1563 #1566 #1507)
- SamsungAc: Use `sendExtended()` going forward. (#1484 #1562)
- SamsungAc: Redo/fix checksum calculations. (#1538 #1554)
- LG: Add support for `AKB73757604` model (#1531 #1545)
- Daikin176: Add support for Unit Id. (#1543 #1544)
- Daikin2: Add support for Humidity setting/operation. (#1535 #1540)
- TCL112AC: Add support for quiet/mute setting. (#1528 #1529)
- LG2: Add Fan speed, Swing, & Light support for new `AKB74955603` model (#1513 #1530)
- Add Mitsubishi AC "fan only" mode (#1527)

**[Misc]**
- Change when some github workflows run (#1583)
- Add/update supported device info (#1580 #1581 #1585)
- Fix pylint issues due to pylint update. (#1569 #1570)
- DAIKIN216: Update supported models. (#1552 #1567)
- IRMQTTServer: Build a minimal OTA image via PlatformIO. (#1513 #1541)
- Reduce memory fragmentation cause by String usage. (#1493 #1536)
- Refactor `decodeMitsubishiAC()` (#1523 #1532)
- Fix incorrect comment.
- Migrate from Travis to GitHub Actions (#1522 #1526)
- Documentation update with additional supported Panasonic AC models (#1525)
crankyoldgit added a commit that referenced this pull request Aug 28, 2021
## _v2.7.20 (20210828)_

**[Bug Fixes]**
- Make `strToSwingH()` match "Right Max" (#1550 #1551)

**[Features]**
- Experimental Bose remote support (#1579)
- Added MitsubishiAC VaneLeft (#1572 #1576)
- HAIER_AC176: Add experimental detailed support (#1480 #1571)
- Detailed support for Tornado/Sanyo 88-bit A/C protocol (#1503 #1568)
- Add support for new `TROTEC_3550` A/C protocol (#1563 #1566 #1507)
- SamsungAc: Use `sendExtended()` going forward. (#1484 #1562)
- SamsungAc: Redo/fix checksum calculations. (#1538 #1554)
- LG: Add support for `AKB73757604` model (#1531 #1545)
- Daikin176: Add support for Unit Id. (#1543 #1544)
- Daikin2: Add support for Humidity setting/operation. (#1535 #1540)
- TCL112AC: Add support for quiet/mute setting. (#1528 #1529)
- LG2: Add Fan speed, Swing, & Light support for new `AKB74955603` model (#1513 #1530)
- Add Mitsubishi AC "fan only" mode (#1527)

**[Misc]**
- Change when some github workflows run (#1583)
- Add/update supported device info (#1580 #1581 #1585)
- Fix pylint issues due to pylint update. (#1569 #1570)
- DAIKIN216: Update supported models. (#1552 #1567)
- IRMQTTServer: Build a minimal OTA image via PlatformIO. (#1513 #1541)
- Reduce memory fragmentation cause by String usage. (#1493 #1536)
- Refactor `decodeMitsubishiAC()` (#1523 #1532)
- Fix incorrect comment.
- Migrate from Travis to GitHub Actions (#1522 #1526)
- Documentation update with additional supported Panasonic AC models (#1525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TODO] Do less with/move away from Travis.
2 participants