Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAIER_AC176: Add experimental detailed support #1571

Merged
merged 4 commits into from
Aug 26, 2021
Merged

HAIER_AC176: Add experimental detailed support #1571

merged 4 commits into from
Aug 26, 2021

Conversation

crankyoldgit
Copy link
Owner

  • IRHaierACYRW02 inherits from the new IRHaierAC176.
    • Except for a few functions that need to be special.
  • Add [sg]et(On|Off)Timer() & [sg]etTimerMode() class methods.
  • Update toString().
  • Add timer specific unit tests.
  • Update existing Unit Tests.
  • Add it to the Common A/C API (IRac)
  • Expand & update the unit tests.

Fixes #1480

@crankyoldgit
HAIER_AC176: Add experimental detailed support
2d24333 
* `IRHaierACYRW02` inherits from the new `IRHaierAC176`.
  - Except for a few functions that need to be special.
* Add it to the Common A/C API (`IRac`)
* Expand & update the unit tests.

Not fully happy with the support yet.

Fixes #1480
@crankyoldgit
Haier176/YRW02: Add On/Off Timer support.
9a0367a 
* Add `[sg]et(On|Off)Timer()` class methods.
* Update `toString()`.
* Add timer specific unit tests.
* Update existing Unit Tests.

For #1480
@crankyoldgit
HaierYrw02: Add Timer Mode support.
392c32a 
Ref: https://docs.google.com/spreadsheets/d/1wdOVS08wgK2pEP7hTZLYMmrQ9FZVmLpZF2HjNQaVxlU/edit?disco=AAAAOCMm-Gg
For #1480
@crankyoldgit crankyoldgit added enhancement Pending Confirmation Waiting for confirmation from user labels Aug 23, 2021
@crankyoldgit crankyoldgit requested a review from NiKiZe August 23, 2021 05:45
@crankyoldgit crankyoldgit self-assigned this Aug 23, 2021
NiKiZe
NiKiZe approved these changes Aug 23, 2021
View reviewed changes
src/ir_Haier.cpp Outdated Show resolved Hide resolved
test/ir_Haier_test.cpp
"Timer Mode: 0 (N/A), On Timer: Off, Off Timer: Off",
ac.toString());
/* Disabled pending:
https://github.com/crankyoldgit/IRremoteESP8266/issues/1480#issuecomment-885636790
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No resolution here?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly no. :-(

Possible case of poorly described data being reported as the set/reported Temperature doesn't match the state[] data supplied.

Also, no simple/easy other state[]s to copy from to try to rebuild a known good state from.

@crankyoldgit
Copy link
Owner Author

Confirmed working in: #1480 (comment)

@crankyoldgit crankyoldgit removed the Pending Confirmation Waiting for confirmation from user label Aug 26, 2021
@crankyoldgit crankyoldgit merged commit 23b6644 into master Aug 26, 2021
@crankyoldgit crankyoldgit deleted the Haier176_detailed branch August 28, 2021 06:20
crankyoldgit added a commit that referenced this pull request Aug 28, 2021
@crankyoldgit
v2.7.20 release
1fbac6c 
_v2.7.20 (20210828)_

**[Bug Fixes]**
- Make `strToSwingH()` match "Right Max" (#1550 #1551)

**[Features]**
- Experimental Bose remote support (#1579)
- Added MitsubishiAC VaneLeft (#1572 #1576)
- HAIER_AC176: Add experimental detailed support (#1480 #1571)
- Detailed support for Tornado/Sanyo 88-bit A/C protocol (#1503 #1568)
- Add support for new `TROTEC_3550` A/C protocol (#1563 #1566 #1507)
- SamsungAc: Use `sendExtended()` going forward. (#1484 #1562)
- SamsungAc: Redo/fix checksum calculations. (#1538 #1554)
- LG: Add support for `AKB73757604` model (#1531 #1545)
- Daikin176: Add support for Unit Id. (#1543 #1544)
- Daikin2: Add support for Humidity setting/operation. (#1535 #1540)
- TCL112AC: Add support for quiet/mute setting. (#1528 #1529)
- LG2: Add Fan speed, Swing, & Light support for new `AKB74955603` model (#1513 #1530)
- Add Mitsubishi AC "fan only" mode (#1527)

**[Misc]**
- Fix pylint issues due to pylint update. (#1569 #1570)
- DAIKIN216: Update supported models. (#1552 #1567)
- IRMQTTServer: Build a minimal OTA image via PlatformIO. (#1513 #1541)
- Reduce memory fragmentation cause by String usage. (#1493 #1536)
- Refactor `decodeMitsubishiAC()` (#1523 #1532)
- Fix incorrect comment.
- Migrate from Travis to GitHub Actions (#1522 #1526)
- Documentation update with additional supported Panasonic AC models (#1525)
@crankyoldgit crankyoldgit mentioned this pull request Aug 28, 2021
Merged
crankyoldgit added a commit that referenced this pull request Aug 28, 2021
@crankyoldgit
v2.7.20 release
e8dee1a 
_v2.7.20 (20210828)_

**[Bug Fixes]**
- Make `strToSwingH()` match "Right Max" (#1550 #1551)

**[Features]**
- Experimental Bose remote support (#1579)
- Added MitsubishiAC VaneLeft (#1572 #1576)
- HAIER_AC176: Add experimental detailed support (#1480 #1571)
- Detailed support for Tornado/Sanyo 88-bit A/C protocol (#1503 #1568)
- Add support for new `TROTEC_3550` A/C protocol (#1563 #1566 #1507)
- SamsungAc: Use `sendExtended()` going forward. (#1484 #1562)
- SamsungAc: Redo/fix checksum calculations. (#1538 #1554)
- LG: Add support for `AKB73757604` model (#1531 #1545)
- Daikin176: Add support for Unit Id. (#1543 #1544)
- Daikin2: Add support for Humidity setting/operation. (#1535 #1540)
- TCL112AC: Add support for quiet/mute setting. (#1528 #1529)
- LG2: Add Fan speed, Swing, & Light support for new `AKB74955603` model (#1513 #1530)
- Add Mitsubishi AC "fan only" mode (#1527)

**[Misc]**
- Change when some github workflows run (#1583)
- Add/update supported device info (#1580 #1581 #1585)
- Fix pylint issues due to pylint update. (#1569 #1570)
- DAIKIN216: Update supported models. (#1552 #1567)
- IRMQTTServer: Build a minimal OTA image via PlatformIO. (#1513 #1541)
- Reduce memory fragmentation cause by String usage. (#1493 #1536)
- Refactor `decodeMitsubishiAC()` (#1523 #1532)
- Fix incorrect comment.
- Migrate from Travis to GitHub Actions (#1522 #1526)
- Documentation update with additional supported Panasonic AC models (#1525)
crankyoldgit added a commit that referenced this pull request Aug 28, 2021
@crankyoldgit
v2.7.20 release (#1582)
21e7dd4 
## _v2.7.20 (20210828)_

**[Bug Fixes]**
- Make `strToSwingH()` match "Right Max" (#1550 #1551)

**[Features]**
- Experimental Bose remote support (#1579)
- Added MitsubishiAC VaneLeft (#1572 #1576)
- HAIER_AC176: Add experimental detailed support (#1480 #1571)
- Detailed support for Tornado/Sanyo 88-bit A/C protocol (#1503 #1568)
- Add support for new `TROTEC_3550` A/C protocol (#1563 #1566 #1507)
- SamsungAc: Use `sendExtended()` going forward. (#1484 #1562)
- SamsungAc: Redo/fix checksum calculations. (#1538 #1554)
- LG: Add support for `AKB73757604` model (#1531 #1545)
- Daikin176: Add support for Unit Id. (#1543 #1544)
- Daikin2: Add support for Humidity setting/operation. (#1535 #1540)
- TCL112AC: Add support for quiet/mute setting. (#1528 #1529)
- LG2: Add Fan speed, Swing, & Light support for new `AKB74955603` model (#1513 #1530)
- Add Mitsubishi AC "fan only" mode (#1527)

**[Misc]**
- Change when some github workflows run (#1583)
- Add/update supported device info (#1580 #1581 #1585)
- Fix pylint issues due to pylint update. (#1569 #1570)
- DAIKIN216: Update supported models. (#1552 #1567)
- IRMQTTServer: Build a minimal OTA image via PlatformIO. (#1513 #1541)
- Reduce memory fragmentation cause by String usage. (#1493 #1536)
- Refactor `decodeMitsubishiAC()` (#1523 #1532)
- Fix incorrect comment.
- Migrate from Travis to GitHub Actions (#1522 #1526)
- Documentation update with additional supported Panasonic AC models (#1525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiKiZe NiKiZe NiKiZe approved these changes

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HAIER_AC_YRW02 remote doubt
2 participants
@crankyoldgit @NiKiZe