Convert AutoAnalyseRawData script to Python #454
Conversation
Mostly a direct port from the Bash shell code to python Some minor features were dropped. Some new ones added.
Rename python analysis script to snake_case format.
|
ATTN reviewers. If you don't know Python, please say so, and I'll find someone who does. |
* Make analyse script code unittest-able. * Improve raw data parsing for analyse script. * Add some unit tests for analyse script. * Update Makefile(s) to use 'run_tests' to run their tests. * Add python unit & lint tests into Travis
crankyoldgit
force-pushed
the
analyse_python
branch
from
550554d to
314811c
Compare
|
Friendly reviewer ping. (If you don't know python, please say so. :) |
There was a problem hiding this comment.
Only done a visual look over it, but it's looking good. I think Python will be a much better fit :)
We are (were) predominantly a Python shop at work, so very familiar with it. Something we found always worked well is PEP8'ing all code, and recently we have moved to black - I'm happy to do do this conversion once the PR is merged if you are OK with it.
Thanks!
|
I've gone with google variant of PEP8 style guide. It's pretty much the same. Mostly because we are using the Google C++ style guide/linter. Also, I've installed |
**[Bug Fixes]** - Fix crash in IRMQTTServer when compiled under Arduino IDE. (#455) - Default bit length not set for RCMM in IRMQTTServer example. (#456) - Bad acknowledgements for some A/C protocols in IRMQTTServer example. (#460) **[Features]** - Allow disabling the use of delay() calls. (#450) - Initial support for G.I. Cable protocol. (#458) - Support of Hitachi A/C 13 & 53 byte messages. (#461) **[Misc]** - Auto Analyse Raw Data script converted to Python. (#454)
Mostly a direct port from the Bash shell code to python
Some minor features were dropped. Some new ones added.
Old script removed.