BUG: IRMQTTServer: Incorrect acknowledgements for some A/C protocols. #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DiggiD Can you please test this to see if it gives the correct results in the serial output and via MQTT? |
Forgot to update this section of code for other A/C protocols, so using a standard function to keep it up-to-date in future. Fixes #459
|
@DiggiD has confirmed it fixes the issue. |
darshkpatel
approved these changes
May 14, 2018
Merged
crankyoldgit
added a commit
that referenced
this pull request
May 20, 2018
**[Bug Fixes]** - Fix crash in IRMQTTServer when compiled under Arduino IDE. (#455) - Default bit length not set for RCMM in IRMQTTServer example. (#456) - Bad acknowledgements for some A/C protocols in IRMQTTServer example. (#460) **[Features]** - Allow disabling the use of delay() calls. (#450) - Initial support for G.I. Cable protocol. (#458) - Support of Hitachi A/C 13 & 53 byte messages. (#461) **[Misc]** - Auto Analyse Raw Data script converted to Python. (#454)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to update this section of code for other A/C protocols, so using
a standard function to keep it up-to-date in future.
Fixes #459