Experimental support for Samsung 36 bit protocol #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sendSamsung36() & decodeSamsung36() added. * Unit test coverage for those routines. * Update examples. For #621
|
@plin2 has confirmed decoding works in #621 (comment) |
darshkpatel
approved these changes
Feb 26, 2019
|
@darshkpatel Thanks for the quick turn-around on the code review. :-) |
crankyoldgit
added a commit
that referenced
this pull request
Mar 16, 2019
_v2.5.6 (20190316)_ **[Bug Fixes]** - Fix Coolix A/C Class to handle special states better. (#633, #624) **[Features]** - Fix case style for recent A/C protocols. (#631) - Update `IRsend::send()` to include all simple protocols. (#629, #628) - Experimental basic support for 112 bit TCL AC messages (#627, #619) - Add support for TECO AC (#622) - Experimental support for Samsung 36 bit protocol (#625, #621) **[Misc]** - Set Coolix to default to 1 repeat. (#637, #636, #624, #439) - Set Daikin2 modulation to 36.7kHz. (#635) - Refactor IRVestelAC class to use portable code. (#617) - Adjust Daikin2 timings and tolerance. (#616, #582)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Mar 16, 2019
_v2.5.6 (20190316)_ **[Bug Fixes]** - Fix Coolix A/C Class to handle special states better. (#633, #624) **[Features]** - Fix case style for recent A/C protocols. (#631) - Update `IRsend::send()` to include all simple protocols. (#629, #628) - Experimental basic support for 112 bit TCL AC messages (#627, #619) - Add support for TECO AC (#622) - Experimental support for Samsung 36 bit protocol (#625, #621) **[Misc]** - Set Coolix to default to 1 repeat. (#637, #636, #624, #439) - Set Daikin2 modulation to 36.7kHz. (#635) - Refactor IRVestelAC class to use portable code. (#617) - Adjust Daikin2 timings and tolerance. (#616, #582)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendSamsung36()&decodeSamsung36()added.For #621