Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IRsend::send() to include all simple protocols. #629

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Update IRsend::send() to include all simple protocols. #629

merged 2 commits into from
Mar 5, 2019

Conversation

crankyoldgit
Copy link
Owner

  • Add missing simple (single integer) IR protocols.
  • Sort the switch statement alphabetically.

Fixes #628

@crankyoldgit
Update IRsend::send() to include all simple protocols.
b6c403f 
- Add missing simple (single integer) IR protocols.
- Sort the switch statement alphabetically.

For #628
@crankyoldgit crankyoldgit self-assigned this Mar 4, 2019
@crankyoldgit
Add unit tests for irsend::send()
ffbe8a8 
Fix sort order
Add missed protocols.

Ref #628
@crankyoldgit crankyoldgit merged commit c1c2153 into master Mar 5, 2019
@crankyoldgit crankyoldgit deleted the issue628 branch March 9, 2019 05:34
crankyoldgit added a commit that referenced this pull request Mar 16, 2019
@crankyoldgit
v2.5.6 Release
1b91bf5 
_v2.5.6 (20190316)_

**[Bug Fixes]**
- Fix Coolix A/C Class to handle special states better. (#633, #624)

**[Features]**
- Fix case style for recent A/C protocols. (#631)
- Update `IRsend::send()` to include all simple protocols. (#629, #628)
- Experimental basic support for 112 bit TCL AC messages (#627, #619)
- Add support for TECO AC (#622)
- Experimental support for Samsung 36 bit protocol (#625, #621)

**[Misc]**
- Set Coolix to default to 1 repeat. (#637, #636, #624, #439)
- Set Daikin2 modulation to 36.7kHz. (#635)
- Refactor IRVestelAC class to use portable code. (#617)
- Adjust Daikin2 timings and tolerance. (#616, #582)
@crankyoldgit crankyoldgit mentioned this pull request Mar 16, 2019
Merged
crankyoldgit added a commit that referenced this pull request Mar 16, 2019
@crankyoldgit
v2.5.6 Release (#639)
b706945 
_v2.5.6 (20190316)_

**[Bug Fixes]**
- Fix Coolix A/C Class to handle special states better. (#633, #624)

**[Features]**
- Fix case style for recent A/C protocols. (#631)
- Update `IRsend::send()` to include all simple protocols. (#629, #628)
- Experimental basic support for 112 bit TCL AC messages (#627, #619)
- Add support for TECO AC (#622)
- Experimental support for Samsung 36 bit protocol (#625, #621)

**[Misc]**
- Set Coolix to default to 1 repeat. (#637, #636, #624, #439)
- Set Daikin2 modulation to 36.7kHz. (#635)
- Refactor IRVestelAC class to use portable code. (#617)
- Adjust Daikin2 timings and tolerance. (#616, #582)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markszabo markszabo markszabo approved these changes

@darshkpatel darshkpatel Awaiting requested review from darshkpatel

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crankyoldgit @markszabo