Basic support for Amcor A/C protocol. #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Appears to be a simple 64 bit protocol with a manditory repeat. * sendAmcor() & decodeAmcor(). - Protocol is NOT space encoded. It's a fixed length bit encoding. * Update IRMQTTServer to be able to send it. NOTE: Bit ordering and bit flipping may happen. This is experimental. For #834
* Observations of temperature data have confirmed I got the bit ordering wrong. - Instead of just changing to LSBFirst order, use LSBF per byte. This will make things easier later. For #834
|
@rahuljawale Thanks for the review. Can I get you to have another quick look at it as I just changed it fundamentally. |
rahuljawale
approved these changes
Jul 28, 2019
|
Thanks again @rahuljawale |
crankyoldgit
added a commit
that referenced
this pull request
Aug 28, 2019
_v2.6.5 (20190828)_ **[Bug Fixes]** - IRMQTTServer: Remove duplicate MQTT_CLIMATE from HA discovery (#869) - Fujitsu: Ensure `on()` is called in common a/c framework. (#862) - Update `strToModel()` (#861) - IRMQTTServer: Add missing header file. (#858) - IRMQTTServer: Fix a compile error when HTML_PASSWORD_ENABLE is enabled. (#856) **[Features]** - IRrecv: Allow receive tolerance percentage to be set at run-time. (#865) - Basic support for Daikin152 A/C protocol. (#874) - Teco: Add light, humid, & save support. (#871) - Detailed support for Amcor A/C protocol. (#836, #854) - IRMQTTServer: Add ability to report Vcc at the ESP chip. (#845) - Gree: Add timer support. (#849) - IRac/Mitsubishi A/C: Support wide `swingh_t` mode (#844) - IRMQTTServer: Generate protocol and bit size html selects (#838) **[Misc]** - New example code to show how to use the `IRac` class to control A/Cs (#839) - Improve/fix `swingh_t::kWide` support (#846) - Kelvinator: Optimise code a little to save space. (#843)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Aug 28, 2019
_v2.6.5 (20190828)_ **[Bug Fixes]** - IRMQTTServer: Remove duplicate MQTT_CLIMATE from HA discovery (#869) - Fujitsu: Ensure `on()` is called in common a/c framework. (#862) - Update `strToModel()` (#861) - IRMQTTServer: Add missing header file. (#858) - IRMQTTServer: Fix a compile error when HTML_PASSWORD_ENABLE is enabled. (#856) **[Features]** - IRrecv: Allow receive tolerance percentage to be set at run-time. (#865) - Basic support for Daikin152 A/C protocol. (#874) - Teco: Add light, humid, & save support. (#871) - Detailed support for Amcor A/C protocol. (#836, #854) - IRMQTTServer: Add ability to report Vcc at the ESP chip. (#845) - Gree: Add timer support. (#849) - IRac/Mitsubishi A/C: Support wide `swingh_t` mode (#844) - IRMQTTServer: Generate protocol and bit size html selects (#838) **[Misc]** - New example code to show how to use the `IRac` class to control A/Cs (#839) - Improve/fix `swingh_t::kWide` support (#846) - Kelvinator: Optimise code a little to save space. (#843)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Bit ordering and bit flipping may happen. This is experimental.
For #834