Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for Daikin152 A/C protocol. #874

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Basic support for Daikin152 A/C protocol. #874

merged 1 commit into from
Aug 28, 2019

Conversation

crankyoldgit
Copy link
Owner

  • Basic support (send & capture) for Daikin152 protcol (Daikin ARC480A5 remote)
  • Unit tests to cover decoding a real message & self-decoding.

For #873

* Basic support (send & capture) for Daikin152 protcol (ARC480A5 remote)
* Unit tests to cover decoding a real message & self-decoding.

For #873
@crankyoldgit
Copy link
Owner Author

Decoding confirmed to be working in #873 (comment)

Copy link
Collaborator

@sillyfrog sillyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
(I do keep thinking about a way to automate that repetitive code for each new protocol, but not had a chance to work on it)
Great work again!

@crankyoldgit
Copy link
Owner Author

I do keep thinking about a way to automate that repetitive code for each new protocol, but not had a chance to work on it

I'm all ears to any ideas to reduce the duplication.

Thanks for the review btw!

@crankyoldgit crankyoldgit merged commit f99b1d6 into master Aug 28, 2019
crankyoldgit added a commit that referenced this pull request Aug 28, 2019
_v2.6.5 (20190828)_

**[Bug Fixes]**
- IRMQTTServer: Remove duplicate MQTT_CLIMATE from HA discovery (#869)
- Fujitsu: Ensure `on()` is called in common a/c framework. (#862)
- Update `strToModel()` (#861)
- IRMQTTServer: Add missing header file. (#858)
- IRMQTTServer: Fix a compile error when HTML_PASSWORD_ENABLE is enabled. (#856)

**[Features]**
- IRrecv: Allow receive tolerance percentage to be set at run-time. (#865)
- Basic support for Daikin152 A/C protocol. (#874)
- Teco: Add light, humid, & save support. (#871)
- Detailed support for Amcor A/C protocol. (#836, #854)
- IRMQTTServer: Add ability to report Vcc at the ESP chip. (#845)
- Gree: Add timer support. (#849)
- IRac/Mitsubishi A/C: Support wide `swingh_t` mode (#844)
- IRMQTTServer: Generate protocol and bit size html selects (#838)

**[Misc]**
- New example code to show how to use the `IRac` class to control A/Cs (#839)
- Improve/fix `swingh_t::kWide` support (#846)
- Kelvinator: Optimise code a little to save space. (#843)
@crankyoldgit crankyoldgit mentioned this pull request Aug 28, 2019
crankyoldgit added a commit that referenced this pull request Aug 28, 2019
_v2.6.5 (20190828)_

**[Bug Fixes]**
- IRMQTTServer: Remove duplicate MQTT_CLIMATE from HA discovery (#869)
- Fujitsu: Ensure `on()` is called in common a/c framework. (#862)
- Update `strToModel()` (#861)
- IRMQTTServer: Add missing header file. (#858)
- IRMQTTServer: Fix a compile error when HTML_PASSWORD_ENABLE is enabled. (#856)

**[Features]**
- IRrecv: Allow receive tolerance percentage to be set at run-time. (#865)
- Basic support for Daikin152 A/C protocol. (#874)
- Teco: Add light, humid, & save support. (#871)
- Detailed support for Amcor A/C protocol. (#836, #854)
- IRMQTTServer: Add ability to report Vcc at the ESP chip. (#845)
- Gree: Add timer support. (#849)
- IRac/Mitsubishi A/C: Support wide `swingh_t` mode (#844)
- IRMQTTServer: Generate protocol and bit size html selects (#838)

**[Misc]**
- New example code to show how to use the `IRac` class to control A/Cs (#839)
- Improve/fix `swingh_t::kWide` support (#846)
- Kelvinator: Optimise code a little to save space. (#843)
@crankyoldgit crankyoldgit deleted the Daikin152 branch August 28, 2019 03:28
@1043717432
Copy link

I do keep thinking about a way to automate that repetitive code for each new protocol, but not had a chance to work on it

I'm all ears to any ideas to reduce the duplication.

Thanks for the review btw!

Successfully written to version 2.6.5, but what does it support on the Aircon web page to support the DAIKIN rc480a5 remote?

@crankyoldgit
Copy link
Owner Author

@1043717432 You need to do the analysis and reverse-engineering to work out which bits in the A/Cs message do what. e.g. Which bits control the power on and off. Which ones are the operating mode and which control the temperature etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants