Fixes #56 Alternative pull-secret info dialog #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evidolob
reviewed
May 10, 2023
src/crc-start.ts
Outdated
| @@ -88,6 +88,10 @@ export async function startCrc( | |||
| } | |||
|
|
|||
| async function askAndStorePullSecret(logger: extensionApi.Logger): Promise<boolean> { | |||
| extensionApi.window.showInformationMessage(`To pull container images from the registry, a pull secret is necessary. You can get a pull secret from the Red Hat OpenShift Local download page by navigating to the dashboard and clicking the "Obtain pull-secret" or opening the following address in your browser https://cloud.redhat.com/openshift/create/local | |||
There was a problem hiding this comment.
await before extensionApi.window.showInformationMessage helps do not show extensionApi.window.showInputBox until user click on Continue
There was a problem hiding this comment.
I considered this... but in this way it is more obvious the dialog is in focus.
It also allows you to actually navigate with the browser and actually paste the value in.
gbraad
force-pushed
the
alternative-pullsecret
branch
from
142e30a to
d1e1170
Compare
evidolob
approved these changes
May 10, 2023
evidolob
approved these changes
May 10, 2023
|
Note: this is hopefully a temporary solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary solution to add an informational dialog before the pull-secret input.