Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing <meta charset="UTF-8"> in head of All contexts and tests #166

Closed
wants to merge 3 commits into from

Conversation

Daodu111
Copy link

@Daodu111 Daodu111 commented Oct 10, 2024

Fixes

Description

I have added the <meta charset="UTF-8"> to all the HTML files.

Technical details

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Daodu111 Daodu111 requested review from a team as code owners October 10, 2024 13:56
@Daodu111 Daodu111 requested review from TimidRobot, Shafiya-Heena, possumbilities, shailee-m and zackkrida and removed request for a team October 10, 2024 13:56
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit a666b0c
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/670986dc70417f00084630db
😎 Deploy Preview https://deploy-preview-166--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@possumbilities possumbilities changed the title Fixed meta issues add missing <meta charset="UTF-8"> in head of All Contexts Oct 11, 2024
@possumbilities possumbilities changed the title add missing <meta charset="UTF-8"> in head of All Contexts add missing <meta charset="UTF-8"> in head of All contexts Oct 11, 2024
@@ -0,0 +1,3 @@
{
"liveServer.settings.port": 5502
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is unrelated to this PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to put the .vscode file in the git ignore file because in a PR I submitted earlier it was requested for another issue. Also it was in this PR that I added it.

Please can you explain a way for me to solve that and also did I meet all the expectations?

Thank you

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you add changes, you should add only the files related to the work you are doing rather than git add -A, in this way it makes sure you can have files present that are not added to a commit.

You would need to remove this file, commit that, and then if you want to add it back be sure to not re add it to the commit again.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the file and committed it, also the changes is in all the HTML files including the tests.

@possumbilities possumbilities changed the title add missing <meta charset="UTF-8"> in head of All contexts add missing <meta charset="UTF-8"> in head of All contexts and tests Oct 11, 2024
@possumbilities
Copy link
Contributor

additionally, the work should include all the html files within the specimen folder, not just the contexts (tests too)

@possumbilities
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug] Missing <meta charset="UTF-8"> in Head of All contexts and tests
3 participants