-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing <meta charset="UTF-8">
in head
of All contexts
and tests
#166
Conversation
✅ Deploy Preview for vocabulary-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
<meta charset="UTF-8">
in head
of All Contexts
<meta charset="UTF-8">
in head
of All Contexts<meta charset="UTF-8">
in head
of All contexts
.vscode/settings.json
Outdated
@@ -0,0 +1,3 @@ | |||
{ | |||
"liveServer.settings.port": 5502 | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is unrelated to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to put the .vscode file in the git ignore file because in a PR I submitted earlier it was requested for another issue. Also it was in this PR that I added it.
Please can you explain a way for me to solve that and also did I meet all the expectations?
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you add changes, you should add only the files related to the work you are doing rather than git add -A
, in this way it makes sure you can have files present that are not added to a commit.
You would need to remove this file, commit that, and then if you want to add it back be sure to not re add it to the commit again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the file and committed it, also the changes is in all the HTML files including the tests.
<meta charset="UTF-8">
in head
of All contexts
<meta charset="UTF-8">
in head
of All contexts
and tests
additionally, the work should include all the |
Fixed by: Closing. |
Fixes
<meta charset="UTF-8">
in Head of All contexts and tests #156 by @possumbilitiesDescription
I have added the
<meta charset="UTF-8">
to all the HTML files.Technical details
Tests
Screenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin