Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add charset meta tag to HTML files for proper character encoding #217

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Add charset meta tag to HTML files for proper character encoding #217

merged 1 commit into from
Oct 15, 2024

Conversation

Faith-K-commits
Copy link
Contributor

Fixes

Description

This pull request adds the <meta charset="UTF-8"> tag to the <head> section of all HTML files in the specimen folder to ensure proper character encoding.

Tests

  1. Open each HTML file in the specimen folder in a web browser.
  2. Inspect the page source to verify that the <meta charset="UTF-8"> tag is present in the <head> section.
  3. Ensure that the pages render correctly without any character encoding issues.

Screenshots

Problem: Missing meta tags
meta-issue

Solution: Add meta tags
meta_tag_solution

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Faith-K-commits Faith-K-commits requested review from a team as code owners October 15, 2024 04:51
@Faith-K-commits Faith-K-commits requested review from TimidRobot, possumbilities, shailee-m and hugosolar and removed request for a team October 15, 2024 04:51
@netlify Netlify
Copy link

netlify bot commented Oct 15, 2024 •
edited
Loading

✅ Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit e8c2962
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/670e6d946289bd0008a5c12a
😎 Deploy Preview https://deploy-preview-217--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Faith-K-commits
Copy link
Contributor Author

Hello @possumbilities
kindly verify if my changes are okay.

@possumbilities
Copy link
Contributor

@Faith-K-commits Why did you close #160 and open a new PR?

This PR is still missing changes to the specimen/tests files

@Faith-K-commits
Copy link
Contributor Author

Hi @possumbilities
I couldn't find a way to do away with the formatting issues so I thought closing it was best but I am still experiencing the same issues. Maybe someone else can work on it.

@Faith-K-commits
Copy link
Contributor Author

@possumbilities , I have corrected my mistakes.

possumbilities
possumbilities approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@possumbilities possumbilities left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you. Approved.

This was referenced Oct 15, 2024
Closed
Closed
@Faith-K-commits
Copy link
Contributor Author

Thank you so much for your patience.

This was referenced Oct 15, 2024
Closed
Closed
@possumbilities possumbilities merged commit 46ff3bb into creativecommons:main Oct 15, 2024
4 checks passed
@possumbilities possumbilities self-assigned this Oct 15, 2024
@possumbilities possumbilities mentioned this pull request Nov 25, 2024
Merged
7 tasks
This was referenced Dec 5, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@possumbilities possumbilities possumbilities approved these changes

Assignees

@possumbilities possumbilities

@Faith-K-commits Faith-K-commits

Labels
None yet
Projects
possumbilities
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Missing <meta charset="UTF-8"> in Head of All contexts and tests
2 participants
@Faith-K-commits @possumbilities