-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: integrate wasmd and bump dependencies (cosmos-sdk and ibc-go) #129
Conversation
- wamsd uses BankKeeper interface alias that is not compatible with customized BlockedAddr function
… and missing pieces in app.go
437aaa7
to
9468c46
Compare
9468c46
to
d38f2ea
Compare
[UPDATE]
|
5fcc710
to
8fdd40c
Compare
Description
This PR adds wasmd v0.29.2 as well as upgrading cosmos-sdk to v1.1.3-sdk-0.45.9 and ibc-go to v3.3.1-crescent-v4-1.
Tasks
cosmos-sdk
andibc-go
respectivelywasmd
inapp.go
farming
module will be deprecated in v4wasmd
does not fully support M1Notes
Adding migration script for
v4
is required when upgrading Crescent chain from v3 to v4. This is because currently running version uses ibc-go v2.2.0-crescent-v3. According to IBC Migration - Support Denoms With Slashes document, chains from a version that does not support base dnoms with slashes (all versions of ibc-go smaller than v2.3.0) require to add migration script to callRunMigrations
so that theapp-transfer
module runs its migration to replace any incorrectly stored trace information. Reference #1680 for a detailed information.Tests
Discussion
wasmd
only supports Intel/AMD64 MacOS and Linux. However, M1 macs are not fully supported. As workflow action inbuild.yml
returns the following error (see the error below), I removearm64
architecture inbuild.yml
file as i thought it was closely related to thewamsd
not supporting M1 macs. However, I am wondering why GasMeter and Gas are not found in the mocks.go file in wasmvm directory and thinking that it might not be due to the supporting M1 macs reason. As it is taking a while to debug, it would be great if @kingcre @crypin can provide some hand here to debug together and find the reason. Right now, I am referencing this Add support for ARM CosmWasm/wasmvm#53 issue and trying to understand wasmvm in depth.(UPDATE) If you read this https://docs.cosmwasm.com/docs/1.0/integration, it states that wamsd currently only supports Intel/AMD64 CPUs and OSX or Linux.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes