build: upgrade ibc-go from v2 to v3 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump ibc-go from v2.2.0 to v3.3.1 - bump cosmos-sdk to v0.45.10 - add v3 upgrade handler script - resolve golang ci linter issues - resolve failing test cases
17 tasks
|
We can discuss if we need to upgrade (UPDATE) We decided to bump ibc-go to v3.4.0 |
queencre
requested review from
crypin,
kingcre,
richard-bachman and
lv-koala
as code owners
I'm not sure if I follow. If you look inside the |
kingcre
reviewed
Dec 20, 2022
queencre
force-pushed
the
124-bump-ibc-go
branch
from
99a5f89
to
b7c94f5
Compare
crypin
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates from ibc-go from v2.2.0 to either v3.3.1.This PR migrates from ibc-go from v2.2.0 to either v3.4.0.
closes: #124
Tasks
MsgLimitOrderandMsgMarketOrdercustom messages)farmingmodule due to reverted customization in cosmos-sdk (dynamic block address)References
Notes
Transferring tokens with slashes from Chain A (ibc-go v3.4.0) to Chain B (ibc-go v2.2.0) fails due to the following error message
ABCI code: 1: error handling packet on destination chain: see events for details. See this transaction hash that is executed to try transferring tokens with slashes from Chain A (ibc-go v3.4.0) to Cosmos Hub (ibc-go v3.0.0 at the time of writing).After doing some research, ABCI code 1 is an internal error and it is coming from
trace info must come in pairs of port and channel identifierserror in this line of code because the IBCtransfermodule expects trace path information to always have an even number of identifiers. It's unfortunate that the events don't tell much about the actual error. Error message handling is improved in v3.4.0 and that is why we need to upgrade Core asap.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Files changedin the Github PR explorerCodecov Reportin the comment section below once CI passes