Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detach in CLI #1107

Closed
michalbiesek opened this issue Sep 16, 2022 · 0 comments · Fixed by #1110
Closed

Detach in CLI #1107

michalbiesek opened this issue Sep 16, 2022 · 0 comments · Fixed by #1110
Assignees
@michalbiesek
Labels
cli
Milestone
Next Feature Vers...

Comments

@michalbiesek
Copy link
Contributor

michalbiesek commented Sep 16, 2022 •
edited
Loading

  • allows for detach/reattach operation on cli
  • new command for detach should be added scope detach
    Here is a short behavior summary
  • when we attach to a process that is in not scoped - as today we create a new session working directory
  • when we attach to a process that is in loaded only - we create a new session working directory
  • we overwrite the configuration during reattach

The problem with the current state is:

  • what we should do when we attach to a process that is scoped state? We will override the previous configuration but this can not be expected - data can be sent to some place and we stop that. To provide a logic based on the scoped/loaded state we need to know in which state the application is. The work on this feature is described in IPC mechanism in AppScope library for Cli #1108
@michalbiesek michalbiesek self-assigned this Sep 16, 2022
michalbiesek added a commit that referenced this issue Sep 16, 2022
@michalbiesek
(#1107) Handle detach/retach operaiton in the cli
cc582a2 
Closes #1107
michalbiesek added a commit that referenced this issue Sep 16, 2022
@michalbiesek
(#1107) Handle detach/retach operation in the cli
3df4e16 
Closes #1107
@michalbiesek michalbiesek mentioned this issue Sep 16, 2022
Merged
@michalbiesek michalbiesek linked a pull request Sep 16, 2022 that will close this issue
Add detach in scope cli #1110
Merged
michalbiesek added a commit that referenced this issue Oct 3, 2022
@michalbiesek
(#1107) Handle detach/retach operation in the cli
3222d64 
Closes #1107
michalbiesek added a commit that referenced this issue Oct 3, 2022
@michalbiesek
(#1107) Handle detach/reattach operation in the cli
e254093 
Closes #1107
michalbiesek added a commit that referenced this issue Oct 4, 2022
@michalbiesek
(#1107) Handle detach/reattach operation in the cli
96e1d60 
Closes #1107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalbiesek michalbiesek

Labels
cli
Projects
None yet
Milestone
Next Feature Version (1.2.0)
Development

Successfully merging a pull request may close this issue.

Add detach in scope cli criblio/appscope
1 participant
@michalbiesek